[Debian-iot-maintainers] RFS: ocf-spec-core

[David Suarez]

Hi,

El dom., 8 mar. 2020 20:25, Carsten Schoenert <c.schoenert at t-online.de>
escribió:

>
> >> I enabled the gitlab CI using the configuration provided by
> salsa-ci-team
>
> Some more specific things.
>
> You have added an override for dh_auto_install but you basically run
> just a copy call here. This isn't needed as we have sequencer files that
> do this, they are needed to be named [binary-package-name].install. So
> instead of having a copy call in debian/rules you should use the
> .install file here. For this package here you would need just one line
> now. The required folder(s) will get created automatically.


> $ cat debian/ocf-spec-core.install
> > swagger2.0/*.swagger.json usr/share/ofc/datamodels
>
> Doing this the override in d/rules is now only containing the chmod
> command. And yes, this is somehow needed. But not in the dh_auto_install
> step. For fixing permissions there is the helper dh_fixperms used.
>

I'm aware that install.* file exists, but I prefer to stick with the
install and fixperms in one point instead of having the install file and
fixperms helper. The package didn't have a build system, so i prefer to
reflect it in the debian makefile.

If it wasn't need to specify the files in the fixperms override, I had been
go for the other way.

On the other way, now that I see it, the first chmod expasion is not needed.

But one more thing you need to have in mind here. Some shells on other
> platforms can't handle the wildcard sign * and your package would
> getting FTBFS than, so you will need to do this differently. Using find
> will work on all platforms, so I'd do it this way finally.
>

Glob is not posix/sus v3?


> > diff --git a/debian/rules b/debian/rules
> > index be0389a..2ab173c 100755
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -7,7 +7,6 @@
> >  %:
> >         dh $@
> >
> > -override_dh_auto_install:
> > -       mkdir -p debian/ocf-spec-core/usr/share/ofc/datamodels
> > -       cp -a swagger2.0/*.swagger.json
> debian/ocf-spec-core/usr/share/ofc/datamodels
> > -       chmod ugo-x swagger2.0/*.swagger.json
> debian/ocf-spec-core/usr/share/ofc/datamodels/*
> > +override_dh_fixperms:
> > +       dh_fixperms
> > +       find debian/ocf-spec-core/usr/share/ofc/datamodels -type f -exec
> chmod 644 {} \;

And one more generic suggestion, I'd like to point to DEP 14. Maybe you
> already know about this.
>
> https://dep-team.pages.debian.net/deps/dep14/
>
> Consider a branch renaming from master to debian/sid. No package upload
> did happen yet so it's easy now to squash existing data and do a clean
> new upload if you agree. If you have problems doing this I can help out
> here of course.
>

As is a draft, I prefer to stick with the clasic layout
master/upstream/pristine-tar.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-iot-maintainers/attachments/20200308/9a7f4eea/attachment-0001.html>