[med-svn] [Git][med-team/snap-aligner][master] Add missing return in a non-void function

Liubov Chuprikova gitlab at salsa.debian.org
Sun Feb 3 10:12:42 GMT 2019


Liubov Chuprikova pushed to branch master at Debian Med / snap-aligner


Commits:
a83c5dd9 by Liubov Chuprikova at 2019-02-03T10:11:53Z
Add missing return in a non-void function

- - - - -


3 changed files:

- debian/changelog
- + debian/patches/add_missing_return.patch
- debian/patches/series


Changes:

=====================================
debian/changelog
=====================================
@@ -1,5 +1,6 @@
 snap-aligner (1.0~beta.18+dfsg-3) UNRELEASED; urgency=medium
 
+  [ Andreas Tille ]
   * Team upload.
   * debhelper 11
   * Point Vcs fields to salsa.debian.org
@@ -7,28 +8,9 @@ snap-aligner (1.0~beta.18+dfsg-3) UNRELEASED; urgency=medium
   * Respect DEB_BUILD_OPTIONS in override_dh_auto_test target
   * Install NOTICE.txt of Apache licensed files
   * Propagate hardening options
-  TODO: With hardening options switched on build time test suite runs into
-    LandauVishkinTest:
-    - equal strings: [OK]
-    - prefixes: [OK]
-    - non-equal strings: [OK]
-    - overly distant strings: [OK]
-    - CIGAR strings: [OK]
-    
-    EventTest:
-    - many waiters: make[1]: *** [debian/rules:17: override_dh_auto_test] Segmentation fault
-
-  When installing gdb in pbuilder chroot and run
-     gdb unit_tests
-     run
-
-    EventTest:
-    - many waiters: [New Thread 0x7ffff77f9700 (LWP 786)]
-    [Thread 0x7ffff77f9700 (LWP 786) exited]
-    
-    Thread 1 "unit_tests" received signal SIGSEGV, Segmentation fault.
-    0x00007ffff7a5f6b0 in pthread_mutex_lock () from /lib/x86_64-linux-gnu/libpthread.so.0
 
+  [ Liubov Chuprikova ]
+  * Add missing return in a non-void function
 
  -- Andreas Tille <tille at debian.org>  Fri, 26 Oct 2018 14:23:56 +0200
 


=====================================
debian/patches/add_missing_return.patch
=====================================
@@ -0,0 +1,15 @@
+Author: Liubov Chuprikova <chuprikovalv at gmail.com>
+Last-Update: Sat, 02 Feb 2019 23:12:29 +0100
+Description: Add missing return that causes segfault
+
+
+--- a/SNAPLib/Compat.cpp
++++ b/SNAPLib/Compat.cpp
+@@ -1119,6 +1119,7 @@
+     bool destroy() {
+         pthread_cond_destroy(&cond);
+         pthread_mutex_destroy(&lock);
++	return true;
+     }
+ };
+ 


=====================================
debian/patches/series
=====================================
@@ -3,3 +3,4 @@ drop-msse
 spelling
 finish-rename
 hardening.patch
+add_missing_return.patch



View it on GitLab: https://salsa.debian.org/med-team/snap-aligner/commit/a83c5dd9ed9bd11063f789ddc196fa949e8f33ac

-- 
View it on GitLab: https://salsa.debian.org/med-team/snap-aligner/commit/a83c5dd9ed9bd11063f789ddc196fa949e8f33ac
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-commit/attachments/20190203/cfe71437/attachment-0001.html>


More information about the debian-med-commit mailing list