[med-svn] [Git][med-team/clustalo][master] Fix memory leak that fixes a typoed ifdef and a missing free()

[Andreas Tille]

Andreas Tille pushed to branch master at Debian Med / clustalo


Commits:
9c43fd13 by Andreas Tille at 2020-04-19T09:33:46+02:00
Fix memory leak that fixes a typoed ifdef and a missing free()

- - - - -


3 changed files:

- debian/changelog
- + debian/patches/memory_leak.patch
- debian/patches/series


Changes:

=====================================
debian/changelog
=====================================
@@ -3,6 +3,7 @@ clustalo (1.2.4-6) UNRELEASED; urgency=medium
   [ Matthew Fernand ]
   * Fix some issues with logging calls
   * Increase field boundaries to avoid out of range access
+  * Fix memory leak that fixes a typoed ifdef and a missing free()
 
  -- Andreas Tille <tille at debian.org>  Fri, 17 Apr 2020 17:06:22 +0200
 


=====================================
debian/patches/memory_leak.patch
=====================================
@@ -0,0 +1,28 @@
+From: Matthew Fernandez <matthew.fernandez at gmail.com>
+Date: Sat, 18 Apr 2020 13:15:49 -0700
+Bug-Debian: https://bugs.debian.org/956324
+Origin: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956324#74
+Description: Fix memory leak that fixes a typoed ifdef and a missing free()
+
+--- a/src/squid/clustal.c
++++ b/src/squid/clustal.c
+@@ -207,7 +207,7 @@ WriteClustal(FILE *fp, MSA *msa)
+   int    namelen;		/* maximum name length used      */
+   int    pos;			/* position counter              */
+ #ifdef CLUSTALO
+-  char  *buf;    	        /* buffer for writing seq        */
++  char  *buf = NULL;   	        /* buffer for writing seq        */
+   int    cpl = msa->alen<iWrap ? msa->alen+10 : (iWrap > 0 ? iWrap : 60);		/* char per line (< 64)          */
+ #else
+   char   buf[80];	        /* buffer for writing seq        */
+@@ -410,8 +410,9 @@ WriteClustal(FILE *fp, MSA *msa)
+ #endif
+     }
+ 
+-#ifdef CLUSTAL
++#ifdef CLUSTALO
+   free(piResCnt); piResCnt = NULL;
++  free(buf); buf = NULL;
+ #endif
+ 
+   return;


=====================================
debian/patches/series
=====================================
@@ -1,2 +1,3 @@
 clustalo-log-format-calls.patch
 array_out_of_bounds.patch
+memory_leak.patch



View it on GitLab: https://salsa.debian.org/med-team/clustalo/-/commit/9c43fd1341dfbe127be2a2d506d5d26a8de63f0e

-- 
View it on GitLab: https://salsa.debian.org/med-team/clustalo/-/commit/9c43fd1341dfbe127be2a2d506d5d26a8de63f0e
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-commit/attachments/20200419/e6892eb9/attachment-0001.html>