[med-svn] [Git][med-team/bart][master] 4 commits: do not assume flaky tests on some archs anymore
Martin Uecker (@uecker-guest)
gitlab at salsa.debian.org
Sat May 9 20:15:30 BST 2026
Martin Uecker pushed to branch master at Debian Med / bart
Commits:
a51dd114 by Martin Uecker at 2026-05-09T14:58:27+02:00
do not assume flaky tests on some archs anymore
- - - - -
6ca32bb8 by Martin Uecker at 2026-05-09T15:01:08+02:00
turn off all workarounds for now
- - - - -
914b03a8 by Martin Uecker at 2026-05-09T15:27:06+02:00
remove feature for local use
- - - - -
b49c6f1d by Martin Uecker at 2026-05-09T21:14:26+02:00
fix Debian tests
- - - - -
5 changed files:
- + debian/patches/0006-remove-exec-command-mechanism.patch
- + debian/patches/0007-fix-initialization-for-direct-call-of-tools.patch
- debian/patches/series
- debian/rules
- debian/tests/control
Changes:
=====================================
debian/patches/0006-remove-exec-command-mechanism.patch
=====================================
@@ -0,0 +1,50 @@
+From: Martin Uecker <uecker at tugraz.at>
+Date: Sat, 9 May 2026 15:26:33 +0200
+Subject: remove exec command mechanism
+
+---
+ src/bart.c | 23 -----------------------
+ 1 file changed, 23 deletions(-)
+
+diff --git a/src/bart.c b/src/bart.c
+index 5f820d0..dbcc65f 100644
+--- a/src/bart.c
++++ b/src/bart.c
+@@ -61,9 +61,6 @@
+
+ #include "main.h"
+
+-// also check in commands/ subdir at the bart exe location
+-#define CHECK_EXE_COMMANDS
+-
+ #ifndef DIMS
+ #define DIMS 16
+ #endif
+@@ -642,27 +639,7 @@ int main_bart(int argc, char* argv[argc])
+
+ debug_printf(DP_DEBUG3, "No builtin found: %s\n", argv[0]);
+
+-#ifdef CHECK_EXE_COMMANDS
+- // also check dirname(PATH_TO_BART)/commands/:
+- char exe_loc[1024] = { };
+- ssize_t exe_loc_size = ARRAY_SIZE(exe_loc);
+- ssize_t rl = readlink("/proc/self/exe", exe_loc, (size_t)exe_loc_size);
+-
+- char* exe_dir = NULL;
+-
+- if ((-1 != rl) && (exe_loc_size != rl)) {
+-
+- // readlink returned without error and did not truncate
+- exe_dir = dirname(exe_loc);
+- // no need to check for NULL, as in that case, we skip it in the loop below
+- }
+-#endif
+-
+ const char* tpath[] = {
+-#ifdef CHECK_EXE_COMMANDS
+- exe_dir,
+-#endif
+- getenv("BART_TOOLBOX_PATH"),
+ "/usr/local/lib/bart/",
+ "/usr/lib/bart/",
+ };
=====================================
debian/patches/0007-fix-initialization-for-direct-call-of-tools.patch
=====================================
@@ -0,0 +1,61 @@
+From: Martin Uecker <uecker at tugraz.at>
+Date: Sat, 9 May 2026 19:38:24 +0200
+Subject: fix initialization for direct call of tools
+
+---
+ src/bart.c | 6 +++++-
+ src/misc/mmio.c | 2 +-
+ tests/bart.mk | 13 +++++++++++++
+ 3 files changed, 19 insertions(+), 2 deletions(-)
+ create mode 100644 tests/bart.mk
+
+diff --git a/src/bart.c b/src/bart.c
+index dbcc65f..0639298 100644
+--- a/src/bart.c
++++ b/src/bart.c
+@@ -537,8 +537,12 @@ int main_bart(int argc, char* argv[argc])
+ parse_bart_opts(&argc, &argv, order, &ref_stream);
+
+ bn = basename(argv[0]);
+- }
+
++ } else {
++
++ for (int i = 0; i < DIMS; i++)
++ order[i] = i;
++ }
+
+ main_fun_t* dispatch_func = NULL;
+
+diff --git a/src/misc/mmio.c b/src/misc/mmio.c
+index be0995f..eb2a235 100644
+--- a/src/misc/mmio.c
++++ b/src/misc/mmio.c
+@@ -150,7 +150,7 @@ struct cfl_loop_desc_s {
+
+ static struct cfl_loop_desc_s cfl_loop_desc = {
+
+- .D = 0,
++ .D = DIMS,
+ .omp_threads = 1,
+ .flags = 0UL,
+ .loop_dims = { [0 ... DIMS - 1] = 1 },
+diff --git a/tests/bart.mk b/tests/bart.mk
+new file mode 100644
+index 0000000..e7db22f
+--- /dev/null
++++ b/tests/bart.mk
+@@ -0,0 +1,13 @@
++
++
++tests/test-bart: bart
++ set -e; mkdir $(TESTS_TMP) ; cd $(TESTS_TMP) ;\
++ $(ROOTDIR)/bart ones 2 1 1 o1.ra ;\
++ cp $(ROOTDIR)/bart ./ones ;\
++ ./ones 2 1 1 o2.ra ;\
++ $(ROOTDIR)/bart nrmse -t 0. o1.ra o2.ra ;\
++ rm ones *.ra ; cd .. ; rmdir $(TESTS_TMP)
++ touch $@
++
++TESTS += tests/test-bart
++
=====================================
debian/patches/series
=====================================
@@ -3,3 +3,5 @@
0003-cleanup-more-thoroughly.patch
0004-remove-rpath.patch
0005-remove-commands-listed-twice.patch
+0006-remove-exec-command-mechanism.patch
+0007-fix-initialization-for-direct-call-of-tools.patch
=====================================
debian/rules
=====================================
@@ -14,12 +14,12 @@ export PARALLEL=1
export PARALLEL_NJOBS=1
# some archs require turning of some optimizations
-NOEXPOPT_ARCHS=arm64 ppc64el s390x ia64 powerpc ppc64 riscv64
+NOEXPOPT_ARCHS=
# turn off hanging tests on i386
-ifeq ($(DEB_BUILD_ARCH), i386)
-export ODE_SIMU_OFF=1
-endif
+#ifeq ($(DEB_BUILD_ARCH), i386)
+#export ODE_SIMU_OFF=1
+#endif
ifneq (,$(filter $(NOEXPOPT_ARCHS), $(DEB_BUILD_ARCH)))
export DEB_CFLAGS_MAINT_APPEND = -fno-expensive-optimizations
@@ -28,10 +28,10 @@ endif
# Some tests fail on the following architectures probably
# due to minor differences in floating point processing.
# For now, just turn it off...
-NOTEST_ARCHS=hurd-i386 kfreebsd-i386
+NOTEST_ARCHS=
# For this architesture the test will be run but it will pass in any case even when errors occure
-PRINT_ERRORS_WHEN_TESTING=sh4 arc m68k alpha loong64
+PRINT_ERRORS_WHEN_TESTING=
%:
dh $@
=====================================
debian/tests/control
=====================================
@@ -12,10 +12,4 @@ Restrictions: superficial
Tests: suite
Depends: bart, make
-Architecture: amd64
Restrictions: allow-stderr
-
-Tests: suite
-Depends: bart, make
-Architecture: i386, mips64el, s390x
-Restrictions: allow-stderr, flaky
View it on GitLab: https://salsa.debian.org/med-team/bart/-/compare/535a71eb34618ca5541c054e933d11533238e282...b49c6f1db92a94e1d171faaa54b8cbb9adfab556
--
View it on GitLab: https://salsa.debian.org/med-team/bart/-/compare/535a71eb34618ca5541c054e933d11533238e282...b49c6f1db92a94e1d171faaa54b8cbb9adfab556
You're receiving this email because of your account on salsa.debian.org. Manage all notifications: https://salsa.debian.org/-/profile/notifications | Help: https://salsa.debian.org/help
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-commit/attachments/20260509/4eb7812c/attachment-0001.htm>
More information about the debian-med-commit
mailing list