[Debian-med-packaging] Bug#648121: SeaView fails to build with hardening options.

[Charles Plessy]

[Cced the public bug report.]

Dear Manolo,

Debian has switched by default some compiler options to “harden” the programs
it distributes.  In my understanding, the goal is to reduce potential security
breaches like buffer overflows etc.

  http://wiki.debian.org/Hardening

Unfortunately, this makes SeaView fail with the following error:

g++ -c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -DUSE_XFT -I/usr/include/freetype2 -DFLTK1 -Dunix -Icsrc -I. -DNO_PDF -Wl,--as-needed -DDEFAULT_HELPFILE=\"/usr/share/doc/seaview/seaview.html\" -DPHYMLNAME=\"phyml\" xfmatpt.cxx
xfmatpt.cxx: In function 'void err_message(const char*)':
xfmatpt.cxx:411:14: error: format not a string literal and no format arguments [-Werror=format-security]
xfmatpt.cxx: In member function 'virtual void matpt_panel::draw()':
xfmatpt.cxx:646:21: error: format not a string literal and no format arguments [-Werror=format-security]
cc1plus: some warnings being treated as errors

You can see the full build log at the following URL:

  http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=seaview_4.3.0-1_amd64.build.gz;att=1;bug=648121

Do you think it would be easy for you to update SeaView in order to solve these
errors ?

Have a nice day,

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan