[Debian-med-packaging] Bug#648121: SeaView fails to build with hardening options.

[Andreas Tille]

Hi,

just find a patch for the problem described below in our packaging SVN

   svn://svn.debian.org/svn/debian-med/trunk/packages/seaview/trunk/debian/patches

As an unrelated remark: It would be really cool if you would ask the
Phylip authors to provide those two files you are using in seaview under
a GPL compatible.  I was negotiating with them several times about using
a free license but failed.  However, it might be feasible for them to
make exceptions for parts of the code like those few files you are using.

Kind regards

          Andreas.

On Wed, Nov 09, 2011 at 01:48:19PM +0900, Charles Plessy wrote:
> [Cced the public bug report.]
> 
> Dear Manolo,
> 
> Debian has switched by default some compiler options to “harden” the programs
> it distributes.  In my understanding, the goal is to reduce potential security
> breaches like buffer overflows etc.
> 
>   http://wiki.debian.org/Hardening
> 
> Unfortunately, this makes SeaView fail with the following error:
> 
> g++ -c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -DUSE_XFT -I/usr/include/freetype2 -DFLTK1 -Dunix -Icsrc -I. -DNO_PDF -Wl,--as-needed -DDEFAULT_HELPFILE=\"/usr/share/doc/seaview/seaview.html\" -DPHYMLNAME=\"phyml\" xfmatpt.cxx
> xfmatpt.cxx: In function 'void err_message(const char*)':
> xfmatpt.cxx:411:14: error: format not a string literal and no format arguments [-Werror=format-security]
> xfmatpt.cxx: In member function 'virtual void matpt_panel::draw()':
> xfmatpt.cxx:646:21: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1plus: some warnings being treated as errors
> 
> You can see the full build log at the following URL:
> 
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=seaview_4.3.0-1_amd64.build.gz;att=1;bug=648121
> 
> Do you think it would be easy for you to update SeaView in order to solve these
> errors ?
> 
> Have a nice day,
> 
> -- 
> Charles Plessy
> Debian Med packaging team,
> http://www.debian.org/devel/debian-med
> Tsurumi, Kanagawa, Japan
> 
> 
> 
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
http://fam-tille.de