[Debian-med-packaging] Bug#690830: other suggestion?

[Andreas Tille]

Hi Emmanuel,

On Wed, Oct 24, 2012 at 08:59:52AM +0200, Emmanuel Promayon wrote:
> Thank you very much Konstantinos for your bug report and patch!
> 
> I think there is another way to fix the bug that seems (to me, but I
> am a beginner) more architecture independent, and I would like to
> know if anyone has an opinion about it.
> 
> Instead of using Konstantinos suggested patch, which consist in
> modify debian/rules, an alternative way would be to add something
> like this directly in the corresponding CMakeLists.txt
> 
> include(TestCXXAcceptsFlag)
> check_cxx_accepts_flag(-fPIC HAS_FPIC_FLAG)
> if(HAS_FPIC_FLAG)
>   set_property(TARGET qtpropertybrowser APPEND PROPERTY
> COMPILE_FLAGS -fPIC)
> endif()
> 
> It checks first if the fPIC flag is accepted by the compiler and
> then adds it. I am not sure it will make a difference for other
> architectures supported by debian.
> What do you think?

Just judging from your explanation (read: without deeper knowledge of
cmake) this sounds to be a more reasonable fix for the problem.  Any
comment of a porter of the architectures in question to verify that it
works as intended would be welcome.

Kind regards

     Andreas.

-- 
http://fam-tille.de