[Debian-med-packaging] Bug#690830: other suggestion?

[Emmanuel Promayon]

Dear Andreas,

do you think it is preferable if we target inclusion in Wheezy to:
- use Konstantinos patch or
- try my other suggestion or
- do nothing as it is taking too much risks to break something else?

Kind regards,


On 24/10/12 09:55, Andreas Tille wrote:
> Hi Emmanuel,
>
> On Wed, Oct 24, 2012 at 08:59:52AM +0200, Emmanuel Promayon wrote:
>> Thank you very much Konstantinos for your bug report and patch!
>>
>> I think there is another way to fix the bug that seems (to me, but I
>> am a beginner) more architecture independent, and I would like to
>> know if anyone has an opinion about it.
>>
>> Instead of using Konstantinos suggested patch, which consist in
>> modify debian/rules, an alternative way would be to add something
>> like this directly in the corresponding CMakeLists.txt
>>
>> include(TestCXXAcceptsFlag)
>> check_cxx_accepts_flag(-fPIC HAS_FPIC_FLAG)
>> if(HAS_FPIC_FLAG)
>>    set_property(TARGET qtpropertybrowser APPEND PROPERTY
>> COMPILE_FLAGS -fPIC)
>> endif()
>>
>> It checks first if the fPIC flag is accepted by the compiler and
>> then adds it. I am not sure it will make a difference for other
>> architectures supported by debian.
>> What do you think?
>
> Just judging from your explanation (read: without deeper knowledge of
> cmake) this sounds to be a more reasonable fix for the problem.  Any
> comment of a porter of the architectures in question to verify that it
> works as intended would be welcome.
>
> Kind regards
>
>       Andreas.
>

-- 
Emmanuel Promayon
UJF-Grenoble 1, CNRS, TIMC-IMAG UMR 5525 (équipe GMCAO)
Institut de l'Ingénierie de l'Information de Santé
Faculté de Médecine - 38706 La Tronche cedex - France
Tel. +33/0 456 52 00 03 - Fax. +33/0 456 52 00 55 - B7