[Debian-med-packaging] Bug#772255: flexbar: bashism in /bin/sh script

[=?UTF-8?Q?R=C3=B6hr at buxtehude.debian.org]

Hey,

exit codes are now adjusted to 1 in the upstream
repository on sourceforge for next release of Flexbar.

Best, Johannes


> On 06 Dec 2014, at 12:57, Raphael Geissert <atomo64 at gmail.com> wrote:
> 
> Package: flexbar
> Severity: minor
> Version: 2.50-1
> User: debian-release at lists.debian.org
> Usertags: goal-dash
> 
> Hi,
> 
> I've ran checkbashisms (from the 'devscripts' package) over the whole
> archive and I found that your package has a /bin/sh script that uses a
> "bashism".
> 
> checkbashisms' output:
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfasta.sh line 10
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfasta.sh line 23
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfasta.sh line 36
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfasta.sh line 49
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfasta.sh line 62
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfastq.sh line 10
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfastq.sh line 23
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfastq.sh line 36
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfastq.sh line 49
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in
>> ./usr/share/doc/flexbar/examples/flexbar_test_csfastq.sh line 62
>> (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fasta.sh
>> line 10 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fasta.sh
>> line 23 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fasta.sh
>> line 36 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fasta.sh
>> line 49 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fasta.sh
>> line 62 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fastq.sh
>> line 10 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fastq.sh
>> line 23 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fastq.sh
>> line 36 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fastq.sh
>> line 49 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_fastq.sh
>> line 62 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_zip.sh
>> line 10 (exit|return with negative status code):
>> exit -1
>> possible bashism in ./usr/share/doc/flexbar/examples/flexbar_test_zip.sh
>> line 23 (exit|return with negative status code):
>> exit -1
> 
> 
> Not using bash (or a Debian Policy compliant shell interpreter that doesn't
> provide such an extra feature) as /bin/sh is likely to lead to errors or
> unexpected behaviours. Please be aware that dash is the default /bin/sh.
> 
> Please closely examine the above output and the script, and determine
> what the proper severity of the bug is, and adjust it accordingly. If
> it's important or greater please hurry to get this fixed for jessie.
> 
> Hints about how to fix bashisms can be found at:
> https://wiki.ubuntu.com/DashAsBinSh
> 
> Thanks in advance,
> Raphael Geissert
>