[Debian-med-packaging] RFS: piler - genomic repeat discovery

Andreas Tille andreas at an3as.eu
Fri Nov 20 08:03:10 UTC 2015


Hi Afif,

On Thu, Nov 19, 2015 at 11:50:02PM -0800, Afif Elghraoui wrote:
> > uploaded.
> 
> Thanks as always

You are welcome as always. :-)
 
> > IMHO these lines in debian/rules
> > 
> >   include /usr/share/dpkg/default.mk
> > 
> >   export CFLAGS := $(CPPFLAGS) $(CFLAGS)
> > 
> > are not needed.
> 
> The first one isn't really needed (though I like to keep it), but the
> second one is necessary for the hardening flags to go through the build
> system.

OK - may be upstream does not distinguish between CFLAGS and CPPFLAGS ...
 
> > Moreover I hope that ftpmaster will not ask you for the
> > Copyright year which as far as I know belongs to a valid copyright
> > information.
> > 
> 
> There is not really any copyright information provided presumably
> because it's public domain anyway. I just thought to put the author's
> name. I guess we'll see what happens.

Yes - that's why I uploaded before writing this mail.

Kind regards

     Andreas.

-- 
http://fam-tille.de



More information about the Debian-med-packaging mailing list