[Debian-med-packaging] [libssw] 01/01: add missing dep to JDK

[Sascha Steinbiss]

Hi Andreas,

> On Mon, Jul 18, 2016 at 08:58:21AM +0000, Sascha Steinbiss wrote:
>> diff --git a/debian/tests/control b/debian/tests/control
>> index fd7f086..e5392c3 100644
>> --- a/debian/tests/control
>> +++ b/debian/tests/control
>> @@ -2,7 +2,7 @@ Tests: build-lib
>>  Depends: libssw0, libssw-dev, build-essential, zlib1g-dev
>>  
>>  Tests: build-lib-java
>> -Depends: libssw-java
>> +Depends: libssw-java, default-jdk
> 
> Hmmm, I wonder whether this should be rather a dependency in
> debian/control if it seems to be obviously needed?

It is needed to build Java programs against libssw-java during testing.
I'm not sure whether Java libraries need to depend on the JDK, and the
message you quotes seems to indicate otherwise. That is, I wouldn't
expect the library itself to depend on a JDK, but for the tests (whose
whole point it is to compile Java code) it is needed. Hence it's now a
dependency in d/tests/control.

> Moreover I wonder what this should mean:
> 
> W: libssw-java: needless-dependency-on-jre

I've never seen this in my Lintian runs when I was packaging libssw... I
normally always try to address all errors and warnings.

> Something seems to be wrong here - may be asking on debian-java list
> might be a way to clarify proper dependencies.

OK, can do. Does anyone of the more Java-knowledgeable people here
probably know more?

> BTW, I can confirm
> 
> $ file debian/tests/run-example.out
> debian/tests/run-example.out: data
> 
> but I do not need to do extra means to build the package (in pbuilder
> embedded into a testing machine).

OK, good to know. I think I'll see if I can do something about the
output problem in the example tool to stop this from happening, and then
forward my fix upstream. Later today, after work.

Cheers
Sascha


-- 
 The Wellcome Trust Sanger Institute is operated by Genome Research 
 Limited, a charity registered in England with number 1021457 and a 
 company registered in England with number 2742969, whose registered 
 office is 215 Euston Road, London, NW1 2BE.