[Debian-med-packaging] Bug#860018: r-cran-curl: Error in test suite

[Andreas Tille]

Package: r-cran-curl
Severity: normal
Tags: patch

Hi,

Gianfranco Costamagna <locutusofborg at debian.org> informed me via mail
about an issue in the test suite:



Hello Andreas, FYI I just uploaded a fix for testsuite (from upstream)
in Ubuntu

--- r-cran-curl-2.3.orig/tests/testthat/test-certificates.R
+++ r-cran-curl-2.3/tests/testthat/test-certificates.R
@@ -1,8 +1,7 @@
context("Certificate validation")

test_that("Invalid domain raises an error", {
-  expect_is(curl_fetch_memory(httpbin("get"))$status, "integer")
-  fake_url <- paste0("https://", nslookup("httpbin.org"), "/get")
+  fake_url <- paste0("https://", nslookup("www.berkeley.edu"))
expect_error(curl_fetch_memory(fake_url), "certificate")
expect_is(curl_fetch_memory(fake_url, handle = new_handle(ssl_verifyhost = FALSE))$status, "integer")
})
--- r-cran-curl-2.3.orig/tests/testthat/test-cookies.R
+++ r-cran-curl-2.3/tests/testthat/test-cookies.R
@@ -13,8 +13,8 @@ test_that("Add some cookies", {
cookies <- handle_cookies(h);
expect_is(cookies, "data.frame")
expect_equal(nrow(cookies), 2)
-  expect_equal(cookies$name, c("foo","bar"))
-  expect_equal(cookies$value, c("123","ftw"))
+  expect_equal(sort(cookies$name), c("bar", "foo"))
+  expect_equal(sort(cookies$value), c("123","ftw"))
expect_true(all(cookies$expiration == Inf))
})


--- r-cran-curl-2.3.orig/tests/testthat/test-handle.R
+++ r-cran-curl-2.3/tests/testthat/test-handle.R
@@ -32,7 +32,7 @@ test_that("Keep-Alive", {
handle_setopt(h, verbose=FALSE)
})

-test_that("Compression and destorying connection", {
+test_that("Compression and destroying connection", {
con <- curl(httpbin("deflate"), handle = h)
expect_equal(jsonlite::fromJSON(readLines(con))$deflate, TRUE)
expect_false(isOpen(con))



the new upstream 2.4 seems already to be good :)



Gianfranco, I think this is not RC critical and since the package will
be updated after Stretch release anyway I simply keep here a record in
BTS and will commit an upstream upgrade to VCS.


Thanks for bringing up this issue

     Andreas.


-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)