[Debian-med-packaging] Bug#956694: [RFS] spdlog

Nilesh npatra974 at gmail.com
Sun Jun 14 15:42:23 BST 2020


Hi,

I've pushed a patch to the team repo[1] to fix this. I patched
./include/spdlog/tweakme.h: Since this file wasn't getting included to
other .h files, I included this bit.
It looks fine to me.

To test this, I did the following:

1. I wrote my own sample code to just include the libs, and it seems to
work.
2. For purify package: Since Ole did a workaround and uploaded, I
checked out the version w/o those workarounds, and it works.

I did the following:
    $ git checkout debian/2.0.0-4
    $ quilt push remove-GreatCMakeCookOff-dependency.patch
   
Append the following lines to cpp/purify/CMakeLists.txt

++if(logging)
++  target_link_libraries(libpurify "-lspdlog -lfmt")
++endif()

So as to include relevant flags. When build this with my changes to
spdlog applied, build passes! \o/

3. For sopt, the build fails with the logs same as what Ole shared
earlier - but looking at them, it seems that spdlog is probably not
responsible for the failure.
    Maybe something else - I'm not sure here. The fmt errors look like
there's a missing flag "-lfmt" and maybe this will do the trick? I
didn't investigate this further.

Andreas, Please take a look at my changes, if you feel it's good to go,
could you please upload?
That'd be great!

[1]: https://salsa.debian.org/med-team/spdlog

Kind Regards,

Nilesh



More information about the Debian-med-packaging mailing list