[Debian-med-packaging] Bug#953884: FTBFS with Boost 1.71

[Sébastien Jodogne]

Dear Giovanni,


On 14/03/20 14:48, Giovanni Mascellani wrote:
 > your package fails to build with boost1.71. You can find a build log
 > attached. If you want to attempt the build yourself, an updated version
 > of boost-defaults which brings in boost1.71 dependencies can be found
 > adding this line to your sources.list file:
 >
 >    deb https://people.debian.org/~gio/reprepro gio main
 >
 > This bug has severity whishlist for the moment, but it will raised to RC
 > as soon as version 1.71 of Boost is promoted to default.
 >
 > More specifically, your package fails building because of a little
 > problem in the CMake script that probes Boost components. The attached
 > patch should fix the bug.

Thanks for submitting this issue!

Your issue was actually fixed upstream, by the following changeset:
https://bitbucket.org/sjodogne/orthanc/commits/0ba17d2bcdc9da94e4138daede44318e2831b025

As the fix is part of Orthanc 1.6.0 that was released today, I have 
closed this bug report.


> The same bug also happens in other orthanc-* packages, which appear to
> embed an orthanc source copy inside a tarball. Please, fix those as well
> because they are failing in the same way. If you want, I can file bugs.

Yes, please! I'll fix them asap.


> (as a side note: is the code embedding really necessary? In general I
> believe it should be avoided, but that's a different issue)

This is necessary, because the plugins reuse a part of the Orthanc 
source code that is referred to as the "Orthanc framework". The "Orthanc 
framework" mainly corresponds to the "Core" folder of the source 
distribution of Orthanc:
https://bitbucket.org/sjodogne/orthanc/src/Orthanc-1.6.0/Core/

I agree with you that this organization is not optimal, and that we 
should ideally release this framework as a separate library (which would 
lead to two Debian packages such as "liborthanc-framework" and 
"liborthanc-framework-dev").

However, this would necessitate a big refactoring of the upstream 
packages (both for Orthanc and for all its plugins). This refactoring is 
actually planned for 2020, but my priority is now to develop new 
features that are needed by the free software community of medical imaging.

Kind Regards,
Sébastien-


-- 
Sébastien Jodogne
Mail: s.jodogne at orthanc-labs.com
Web: http://www.orthanc-labs.com/
Twitter: https://twitter.com/sjodogne