[Debian-med-packaging] Bug#986201: Bug#986201: fsm-lite: Please provide autopkgtest

Andreas Tille andreas at an3as.eu
Mon Dec 20 16:33:58 GMT 2021


Hi,

Am Mon, Dec 20, 2021 at 07:12:48PM +0530 schrieb Nilesh Patra:
> On 12/20/21 7:07 PM, Lance Lin wrote:
> > Hi Nilesh, Andreas,
> > I chose this approach over static text comparisons since this will work for any input .FASTA file instead of searching for hard-coded values such as '1508'. I am open to your feedback and any improvements.
> > 
> > https://salsa.debian.org/med-team/fsm-lite/-/merge_requests/1
> 
> Thanks Lance, I left a review on your PR. can you address that?

I merged the change and did some fixes.  Please note that AUTOPKGTEST_TMP
is a fixed variable name in CI tests and we should stick to this.  Moreover
it is in general to stick to pure POSIX shell syntax and not to rely on
bash features like [[ ]] if not necessariy.  Finally there was some issue
with the comparison itself.

So far the test works now but I fully agree with Nilesh that an md5sum
based test (as for install in maffilter, probabel and many others) is
better here.  It would be great if you could change it that way.

Kind regards

      Andreas.

-- 
http://fam-tille.de



More information about the Debian-med-packaging mailing list