[Debian-med-packaging] Applied patch in Debian packaging, please review (Was: [samtools/samtools] Replace Curses `mvprintw()` with `va_list`-based equivalent (#1509))

[Andreas Tille]

Hi John,

Am Wed, Oct 06, 2021 at 12:26:27PM +0000 schrieb John Marshall:
> 
> In practice, especially in the long-frozen 0.1.19, curses_mvprintw() is always called with a fmt of "%-d" -- hence str will never contain a '%' character so the problem pointed out by the warning is merely a theoretical one anyway. So both patches are fine and both resolve the theoretical problem. So I concur: it's fine to wait for something else that justifies another upload.
> 
> For ongoing development, my patch is probably better as it simplifies the code and is more efficient (at the cost of using a wider variety of curses functions, but they are equally old curses functions so shouldn't cause any portability issues -- certainly not for Debian which controls the curses in use). For patching the old version, I would probably have just left it as your simple patch :-) (but either's fine).

Thanks for checking and the explanation.  Since I consider your solution
more elegant, I'll keep the new patch and upload whenever a new upload
is needed. 

Kind regards

      Andreas.

-- 
http://fam-tille.de