[Debian-med-packaging] libcifpp_5.0.3-1_amd64.changes REJECTED

[Andrius Merkys]

Hi Thorsten,

Thank you for such a speedy review. We will resolve and reupload.

On 2022-11-14 21:00, Thorsten Alteholz wrote:
> please also mention at least libcifpp-5.0.3/include/cif++/gzio.hpp in your debian/copyright.
> 
> While you are at it, please document in some README, why you need to embed a copy of the boost regex header files.

Maarten, do we need these files for Debian build? CMakeLists.txt say 
that boost regex headers are used to avoid crashing std::regex 
implementation (shouldn't this be fixed in std::regex upstream?). Even 
if so, maybe we can use Debian-provided boost regex headers and unembed 
them from libcifpp?

> Is there a reason why you remove the data update cronjob only when purging the package? Shouldn't that be done when removing it as well?

Removing cronjob at removal makes sense to me as well. IMO, purge should 
only remove the configuration file.

Best,
Andrius