[Debian-med-packaging] libcifpp_5.0.3-1_amd64.changes REJECTED

[Maarten L. Hekkelman]

Hi Andrius, Thorsten,
>
> Thank you for such a speedy review. We will resolve and reupload.

I concur. And I think I resolved the issues. Andrius may try to upload 
again.

About that regex issue, see 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86164

It is a long standing issue and it is a bit frustrating this isn't fixed 
yet. Using the newest header-only boost regex was a very nice solution 
avoiding a dependency on runtime libraries. I understand this is not an 
issue with Debian packages, but it is a very big issue with code 
distributed directly to the average user of my software.

regards, -maarten

>
> On 2022-11-14 21:00, Thorsten Alteholz wrote:
>> please also mention at least libcifpp-5.0.3/include/cif++/gzio.hpp in 
>> your debian/copyright.
>>
>> While you are at it, please document in some README, why you need to 
>> embed a copy of the boost regex header files.
>
> Maarten, do we need these files for Debian build? CMakeLists.txt say 
> that boost regex headers are used to avoid crashing std::regex 
> implementation (shouldn't this be fixed in std::regex upstream?). Even 
> if so, maybe we can use Debian-provided boost regex headers and 
> unembed them from libcifpp?
>
>> Is there a reason why you remove the data update cronjob only when 
>> purging the package? Shouldn't that be done when removing it as well?
>
> Removing cronjob at removal makes sense to me as well. IMO, purge 
> should only remove the configuration file.
>
> Best,
> Andrius 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20221115/0c2c3e78/attachment.htm>