[Debian-med-packaging] Bug#1066300: ampliconnoise: FTBFS: FCluster.c:230:13: error: implicit declaration of function ‘UpdateMinCacheForRow’; did you mean ‘UpdateMinCacheForMarkedRows’? [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: ampliconnoise
Version: 1.29-10
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -c FCluster.c 
> FCluster.c:223:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
>   223 | UpdateMinCacheForMarkedRows(struct t_Min* asMin,float** aafDistMatrix,int nN)
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> FCluster.c: In function ‘UpdateMinCacheForMarkedRows’:
> FCluster.c:230:13: error: implicit declaration of function ‘UpdateMinCacheForRow’; did you mean ‘UpdateMinCacheForMarkedRows’? [-Werror=implicit-function-declaration]
>   230 |             UpdateMinCacheForRow(asMin,i,aafDistMatrix);
>       |             ^~~~~~~~~~~~~~~~~~~~
>       |             UpdateMinCacheForMarkedRows
> FCluster.c: At top level:
> FCluster.c:237:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
>   237 | UpdateMinCacheForRow(struct t_Min* asMin,int i,float** aafDistMatrix)
>       | ^~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [makefile:13: FCluster.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/ampliconnoise_1.29-10_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.