[Debian-med-packaging] Bug#1066334: acedb: FTBFS: acein.c:2045:15: error: implicit declaration of function ‘add_history’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: acedb
Version: 4.9.39+dfsg.02-9
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -Wall  -DACEDB4 `../w3rdparty/include-config glib-2.0` -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -I/usr/include/tirpc  -I.. -I../wh -I../wstaden -DACEDB_GTK -DLINUX -c -o acein.o acein.c
> shift: No more words.
> acein.c: In function ‘aceInPrompt’:
> acein.c:459:9: warning: variable ‘cp’ set but not used [-Wunused-but-set-variable]
>   459 |   char *cp = 0 ;
>       |         ^~
> acein.c: In function ‘aceInOptPrompt’:
> acein.c:504:9: warning: variable ‘cp’ set but not used [-Wunused-but-set-variable]
>   504 |   char *cp;
>       |         ^~
> acein.c: In function ‘aceInGetChar’:
> acein.c:2045:15: error: implicit declaration of function ‘add_history’ [-Werror=implicit-function-declaration]
>  2045 |               add_history(fi->stream[fi->streamlevel].text);
>       |               ^~~~~~~~~~~
> acein.c: In function ‘aceInCard’:
> acein.c:829:7: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   829 |       system ((char*)fi->pos) ;
>       |       ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [<builtin>: acein.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/acedb_4.9.39+dfsg.02-9_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.