[Debian-med-packaging] Bug#1096609: fastdnaml: ftbfs with GCC-15

[Matthias Klose]

Package: src:fastdnaml
Version: 1.2.2-17
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/fastdnaml_1.2.2-17_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |                                     ^~~~~~ ~~~~~~~~~~~~
fastDNAml.c:1774:13: note: declared here
 1774 |     double  randum();
      |             ^~~~~~
fastDNAml.c: In function ‘getxnode’:
fastDNAml.c:2168:9: error: too many arguments to function ‘exit’; expected 0, have 1
 2168 |         exit(1);
      |         ^~~~ ~
fastDNAml.h:218:7: note: declared here
  218 | void  exit();
      |       ^~~~
fastDNAml.c: At top level:
fastDNAml.c:2695:6: error: conflicting types for ‘hookup’; have ‘void(struct noderec *, struct noderec *, double)’
 2695 | void hookup (nodeptr p, nodeptr q, double z)
      |      ^~~~~~
fastDNAml.c:503:11: note: previous declaration of ‘hookup’ with type ‘void(void)’
  503 |     void  hookup();
      |           ^~~~~~
fastDNAml.c:2813:9: error: conflicting types for ‘initrav’; have ‘boolean(tree *, struct noderec *)’ {aka ‘int(tree *, struct noderec *)’}
 2813 | boolean initrav (tree *tr, nodeptr p)
      |         ^~~~~~~
fastDNAml.c:504:14: note: previous declaration of ‘initrav’ with type ‘boolean(void)’ {aka ‘int(void)’}
  504 |     boolean  initrav();
      |              ^~~~~~~
fastDNAml.c: In function ‘writeCheckpoint’:
fastDNAml.c:3231:7: error: too many arguments to function ‘treeOut’; expected 0, have 3
 3231 |       treeOut(checkpointf, tr, treeNewick);
      |       ^~~~~~~ ~~~~~~~~~~~
fastDNAml.c:3227:12: note: declared here
 3227 |     void   treeOut();
      |            ^~~~~~~
fastDNAml.c: At top level:
fastDNAml.c:3643:6: error: conflicting types for ‘treeOut’; have ‘void(FILE *, tree *, int)’
 3643 | void treeOut (FILE *treefile, tree *tr, int form)
      |      ^~~~~~~
fastDNAml.c:3227:12: note: previous declaration of ‘treeOut’ with type ‘void(void)’
 3227 |     void   treeOut();
      |            ^~~~~~~
fastDNAml.c: In function ‘treeOut’:
fastDNAml.c:3652:7: error: too many arguments to function ‘exit’; expected 0, have 1
 3652 |       exit(1);
      |       ^~~~ ~
fastDNAml.h:218:7: note: declared here
  218 | void  exit();
      |       ^~~~
fastDNAml.c: At top level:
fastDNAml.c:4587:8: error: conflicting types for ‘randum’; have ‘double(long int *)’
 4587 | double randum (long  *seed)
      |        ^~~~~~
fastDNAml.c:1774:13: note: previous declaration of ‘randum’ with type ‘double(void)’
 1774 |     double  randum();
      |             ^~~~~~
fastDNAml.c: In function ‘makeDenovoTree’:
fastDNAml.c:4621:12: error: conflicting types for ‘randum’; have ‘double(void)’
 4621 |     double randum();
      |            ^~~~~~
fastDNAml.c:4587:8: note: previous definition of ‘randum’ with type ‘double(long int *)’
 4587 | double randum (long  *seed)
      |        ^~~~~~
fastDNAml.c:4659:11: error: too many arguments to function ‘randum’; expected 0, have 1
 4659 |       j = randum(&(adef->jumble))*(tr->mxtips - tr->ntips) + tr->ntips + 1;
      |           ^~~~~~ ~~~~~~~~~~~~~~~
fastDNAml.c:4621:12: note: declared here
 4621 |     double randum();
      |            ^~~~~~
make[1]: *** [Makefile:4: fastDNAml] Error 1
make[1]: Leaving directory '/build/reproducible-path/fastdnaml-1.2.2'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2