[Debian-med-packaging] Bug#1096612: fastlink: ftbfs with GCC-15

[Matthias Klose]

Package: src:fastlink
Version: 4.1P-fix100+dfsg-5
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/fastlink_4.1P-fix100+dfsg-5_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
 2149 | Local Void mem_collapsedown(p)
      |            ^~~~~~~~~~~~~~~~
comlike.c: In function ‘maxw_estimation’:
comlike.c:2198:7: error: too many arguments to function ‘mem_collapsedown’; expected 0, have 1
 2198 |       mem_collapsedown(proband[ped - 1]);
      |       ^~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
comlike.c:2149:12: note: declared here
 2149 | Local Void mem_collapsedown(p)
      |            ^~~~~~~~~~~~~~~~
comlike.c:2207:5: error: too many arguments to function ‘mem_collapsedown’; expected 0, have 1
 2207 |     mem_collapsedown(proband[ped - 1]);
      |     ^~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
comlike.c:2149:12: note: declared here
 2149 | Local Void mem_collapsedown(p)
      |            ^~~~~~~~~~~~~~~~
automodified.c:852:3: error: too many arguments to function ‘cleanup’; expected 0, have 2
  852 |   cleanup(LINK->q, LINK->LINK);
      |   ^~~~~~~ ~~~~~~~
commondefs.h:1146:13: note: declared here
 1146 | extern void cleanup();
      |             ^~~~~~~
automodified.c:853:3: error: too many arguments to function ‘exitseg’; expected 0, have 1
  853 |   exitseg(LINK);
      |   ^~~~~~~ ~~~~
commondefs.h:1148:13: note: declared here
 1148 | extern void exitseg();
      |             ^~~~~~~
automodified.c: In function ‘segdown’:
automodified.c:861:6: warning: old-style function definition [-Wold-style-definition]
  861 | Void segdown(LINK)
      |      ^~~~~~~
automodified.c:863:1: error: number of arguments doesn’t match prototype
  863 | {
      | ^
commondefs.h:1136:13: error: prototype declaration
 1136 | extern void segdown();
      |             ^~~~~~~
automodified.c:907:3: error: too many arguments to function ‘initseg’; expected 0, have 1
  907 |   initseg(LINK); /*get data about this p,q,children triple*/
      |   ^~~~~~~ ~~~~
commondefs.h:1147:13: note: declared here
 1147 | extern void initseg();
      |             ^~~~~~~
automodified.c:1242:3: error: too many arguments to function ‘cleanup’; expected 0, have 2
 1242 |   cleanup(LINK->p, LINK->LINK);
      |   ^~~~~~~ ~~~~~~~
commondefs.h:1146:13: note: declared here
 1146 | extern void cleanup();
      |             ^~~~~~~
automodified.c:1243:3: error: too many arguments to function ‘cleanup’; expected 0, have 2
 1243 |   cleanup(LINK->q, LINK->LINK);
      |   ^~~~~~~ ~~~~~~~
commondefs.h:1146:13: note: declared here
 1146 | extern void cleanup();
      |             ^~~~~~~
automodified.c:1244:3: error: too many arguments to function ‘exitseg’; expected 0, have 1
 1244 |   exitseg(LINK);
      |   ^~~~~~~ ~~~~
commondefs.h:1148:13: note: declared here
 1148 | extern void exitseg();
      |             ^~~~~~~
make[2]: *** [Makefile:989: looldnuclear.o] Error 1
make[2]: *** [Makefile:1004: automodified.o] Error 1
make[2]: *** [Makefile:971: locomlike.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/fastlink-4.1P-fix100+dfsg/4.1P/src'
dh_auto_build: error: cd 4.1P/src && make -j8 "INSTALL=install --strip-program=true" "CFLAGS=-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/fastlink-4.1P-fix100+dfsg=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon" "DEBIANLDFLAGS=-Wl,-z,relro -Wl,-z,now" returned exit code 2
make[1]: *** [debian/rules:16: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/fastlink-4.1P-fix100+dfsg'
make: *** [debian/rules:9: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2