[Debian-med-packaging] New Sight version

[Flavien BRIDAULT]

Le samedi 01 mars 2025 à 18:25 +0100, Étienne Mollier a écrit :
> Hi Flavien, Hi Andreas,
> 
Hi Etienne,

Thank you for your quick answer. I respond to you in the text below.

> Flavien BRIDAULT, on 2025-03-01:
> > I updated "Sight" package to 25.0.0, and updated all patches. It
> > looks
> > good to me for an upload.
> 
> I took a look at the changes in Salsa.  The package is overall
> in good shape.  I have just spotted the following issues rather
> easy to fix:
> 
>   * The copyright year may be bumped to 2025 upstream, same for
>     the packaging directory.
Done.
> 
>   * The ubuntu1 version suffix is not needed for debian.  :)
Omg, I swear I removed it al least three times but it always comes
back. :) My bad, I fixed it.

> 
>   * Lintian complains about NMU upload, this looks to be caused
>     by mismatched email address between the d/changelog and the
>     d/control.  Please can you update one or both to your
>     preferred contact address?
Fixed in the changelog.

> 
> Apart from that, there is the duplicate Roboto font face which
> may gain being deduplicated with the packaged font, but I also
> concur it's a little more involved and is probably around for a
> while.  If this can be sorted, that would facilitate reading the
> lintian warnings output.
Indeed, this surprises me because I had the intent to remove them in a
previous commit (203e521c). The files are mentioned in the not-
installed but are included in the regex in libsight.install, so I
assume I made a mistake. I had to introduce a new patch but this should
be fine now, thank your for spotting it. I will forward the changes
upstream.
> 
> Thanks Flavien for taking the time to prepare a package of this
> magnitude!  I'm okay with proceeding to an upload after the
> three points are addressed.  Maybe Andreas will have other
> observations if he took some time to have a look.
> 
You are welcome. Thanks again for your feedback and tell me if that's
fine now or if you request any other changes.

> Have a nice day,  :)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20250302/964a5fc6/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 870 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20250302/964a5fc6/attachment.sig>