[Debian-on-mobile-maintainers] Upstream Efforts

[Guido Günther]

Hi,
On Tue, Mar 23, 2021 at 09:48:37AM -0400, Chris Talbot wrote:
> Good Morning Evangalos,
> 
> > This should probably live on salsa.debian.org.
> 
> Fair enough. I cloned my repository:
> 
> https://salsa.debian.org/kop316/mmsd/-/tree/debian/latest
> 
> > Instead of removing -WError I think it would be better to see where
> > the 
> > warning comes from and fix that :)
> 
> While I do agree with you (as that is good practice!), my understanding
> of packaging mmsd at this time is to package upstream mmsd as close as
> possible and only patch upstream mmsd enough to get it to compile
> (which I interpret to mean do not patch warnings, only compiler
> errors). Once mmsd is accepted into Debian, then I can start adding the
> patches I have created to fix issues like this. 
> 
> While I do not mind adding additional patches to fix warnings as well,
> I feel like this conflicts with my understanding of the original
> guidance. As such, could I get clarification on how much I should patch
> upstream mmsd to get it accepted in Debian?

A guideline i came across in Debian is: Enable `-Werror` for development
builds but *disable* it for release builds (as in when building package
for Debian). This keeps you out of trouble with e.g. with newer gcc
versions (*but* it might also make you miss errors).

Given that this is about introducing mmsd to Debian initially and then
expecting larger changes anyway i'd say it's o.k. to disable compile
warnings *initially* and then fix warning upstream and in Debian in
parallel.

Cheers,
 -- Guido

> 
> Respectfully,
> Chris Talbot
> 
> 
> _______________________________________________
> Debian-on-mobile-maintainers mailing list
> Debian-on-mobile-maintainers at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-on-mobile-maintainers
>