[Debian-pan-maintainers] Unifying jupyterlab and node-jupyterlab

[Yadd]

On 6/7/24 19:53, Roland Mas wrote:
> 
> Le 05/06/2024 à 15:24, Yadd a écrit :
>> On 6/5/24 17:18, Roland Mas wrote:
>>>
>>> Le 02/06/2024 à 10:58, Yadd a écrit :
>>>> On 6/2/24 12:53, Yadd wrote:
>>>>> On 6/2/24 10:38, Yadd wrote:
>>>>>> In my last commit, I added also a fix for #1060772:
>>>>>>   - jupyter-lab uses yarnpkg by default
>>>>>>   - in Debian build context, this can be overridden using
>>>>>>     YARN_COMMAND=pkgjs-install-minimal
>>>>>
>>>>> Better hook with "YARN_COMMAND=pkgjs" which uses the adapted 
>>>>> pkgjs-* command
>>>>
>>>> And this produces the final bundle without Internet access
>>>>  => fixes #1060772 :-D
>>>
>>> …wow, you rock. Thanks for all that! I had started a WIP branch but 
>>> was nowhere near completion like yours.
>>>
>>> I'll do some testing on my side and see if anything needs to be 
>>> tweaked on the Python side.
>>>
>>> Thanks!
>>
>> Thank you, I think it's more easy to insert Python hooks into the node 
>> package than the reverse ;-)
>> Anyway I think we should publish starting from src:jupyterlab and not 
>> from src:node-jupyterlab and publish binary:jupyterlab as proposed in 
>> my branch.
> 
> Yeah, when it actually builds again I'll do the moving around. I tweaked 
> yarn.js a bit following your tracks, ensuring it only calls pkgjs-$foo 
> for values of $foo that exist, and renaming an environment variable 
> following https://github.com/yarnpkg/berry/issues/5588; but I'm still 
> stuck when building:

Could you give me a way to reproduce ?