[Debian-pan-maintainers] Bug#1010258: python3-pymca5: flaky autopkgtest on i386

[Julian Gilbey]

On Wed, Apr 27, 2022 at 12:49:55PM +0200, picca wrote:
> On 2022-04-27 11:47, Julian Gilbey wrote:
> > Package: python3-pymca5
> > Version: 5.7.1+dfsg-1
> > Severity: normal
> > X-Debbugs-Cc: Picca Frédéric-Emmanuel <picca at debian.org>
> > 
> > Uploading a new version of python3-qtconsole with only changes to the
> > autopkgtest suite (no changes to the python3 module at all) caused
> > those packages depending on it to be retested on the CI system.  One
> > of these is pymca, and it failed:
> > https://ci.debian.net/data/autopkgtest/testing/i386/p/pymca/21180621/log.gz
> > I tried running it locally and it passed fine, as it did with the
> > previous version of python3-qtconsole.  So it seems that this test is
> > flaky, at least with Python 3.10:
> > 
> > ======================================================================
> > FAIL: testFullViewNumpy (McaStackViewTest.testMcaStackView)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File
> > "/usr/lib/python3/dist-packages/PyMca5/tests/McaStackViewTest.py",
> > line 208, in testFullViewNumpy
> >     self._assertFullView(data)
> >   File
> > "/usr/lib/python3/dist-packages/PyMca5/tests/McaStackViewTest.py",
> > line 274, in _assertFullView
> >     numpy.testing.assert_array_equal(data[idxFull],
> >   File
> > "/usr/lib/python3/dist-packages/numpy/testing/_private/utils.py", line
> > 934, in assert_array_equal
> >     assert_array_compare(operator.__eq__, x, y, err_msg=err_msg,
> >   File
> > "/usr/lib/python3/dist-packages/numpy/testing/_private/utils.py", line
> > 844, in assert_array_compare
> >     raise AssertionError(msg)
> > AssertionError:
> > Arrays are not equal
> > 
> > Mismatched elements: 1 / 1512 (0.0661%)
> > Max absolute difference: 4.54747351e-13
> > Max relative difference: 2.09568557e-16
> >  x: array([[[[1008.747835, 1009.708006, 1010.258788, ..., 1014.26906 ,
> >           1015.457929, 1016.341512],
> >          [1017.31171 , 1018.872885, 1019.41133 , ..., 1023.968694,...
> >  y: array([[[[1008.747835, 1009.708006, 1010.258788, ..., 1014.26906 ,
> >           1015.457929, 1016.341512],
> >          [1017.31171 , 1018.872885, 1019.41133 , ..., 1023.968694,...
> > 
> > ----------------------------------------------------------------------
> > 
> > Unfortunately the output does not show which elements mismatched or
> > what their values were.
> > 
> > I don't know how best to proceed with a flaky test; I could re-upload
> > python3-qtconsole, but that doesn't seem like the best approach.  Or
> > perhaps this test could be marked as flaky or skipped on i386?  It
> > would be very good to resolve this, though, as it's one of the few
> > things blocking spyder from migrating to testing.
> > 
> > Thanks!
> > 
> >    Julian
> 
> 
> Hello Julien, it seems thatt he solution is to relax the comparison in the
> pymca code.
> I am in vacation. So if you want to add a patch to relax this constrain do
> not hesitate.
> Just push this to the pymca salsa code.
> You can upload it if you want.
> 
> cheers
> 
> Fred

Thanks Fred, I'll take a look!

Best wishes,

   Julian