Package syrthes - Request for reviewing

[Sylvestre Ledru]

Le vendredi 11 septembre 2009 à 17:23 +0200, Gilles Filippini a écrit :
> Hi,
> 
> I've packaged the syrthes[0] thermal computation software and since I'm
> not a DD I'd appreciate if someone here could have a look at it.

I have a few comments before upload:
* is it normal to have source files in /usr/lib/ ?
(/usr/lib/syrthes/3.4.2/bin/Makefile)
* there are plenty of data files in /usr/lib 
* /usr/lib/syrthes/3.4.2/example/ will probably be more interesting
in /usr/share/doc/<package>/ 
* There are static lib into your package. Is it really mandatory ?
/usr/lib/syrthes/3.4.2/lib/Linux/libsatsyrthes3.4.2_Linux.a
/usr/lib/syrthes/3.4.2/lib/Linux/libsyrthes3.4.2_Linux.a
/usr/lib/syrthes/3.4.2/lib/Linux/libmainsyrthes3.4.2_Linux.a
* In the README.source, you said that you removed the doc directory from
the tarball. 
Could you add a script which can do it automatically ? (a basic script 
* I added watch file 


Not blocking:
* the manpages don't explain the arguments syrthes2ensight &
syrthes_create_case 


> It is available from its git repo on alioth[1].
> 
> The long description in debian/control says:
> 
>  SYRTHES is a general purpose thermal software developed at EDF R&D
>  which models conduction and radiation heat transfers in complex
>  geometries.
>  .
>  SYRTHES can be used coupled with the computational fluid dynamics (CFD)
>  Code_Saturne.
> 
> With this package I've tried to solve the question[2] I asked a few
> months ago on this list: how to tweak the packaging so that, with the
> same source package, one can build either the binary package "syrthes"
> or "syrthes-<version>" so that there's a simple way to install several
> version of syrthes on the same box while keeping only one in the
> official debian archive. Please see debian/README.source[3] for details.
I understand the rational behind it and it is 
> Thanks in advance,
> 
> _Gilles.
> 
> [0] <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=531902>
> [1] <http://git.debian.org/?p=debian-science/packages/syrthes.git;a=tree>
> [2]
> <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/2009-June/001299.html>
> [3]
> <http://git.debian.org/?p=debian-science/packages/syrthes.git;a=blob_plain;f=debian/README.source;hb=HEAD>
> 
> --
> debian-science-maintainers mailing list
> debian-science-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/debian-science-maintainers