Package syrthes - Request for reviewing

[Sylvestre Ledru]

Sorry for the noise, my previous email wasn't supposed to go...


Le vendredi 11 septembre 2009 à 17:23 +0200, Gilles Filippini a écrit :
> Hi,
> 
> I've packaged the syrthes[0] thermal computation software and since I'm
> not a DD I'd appreciate if someone here could have a look at it.

I have a few comments before upload:
* please try to follow the rules of the policy [1] (Maintainer field), etc (I updated the fields)
* is it normal to have source files in /usr/lib/ ?
(/usr/lib/syrthes/3.4.2/bin/Makefile)
* it is normal to have duplicated files ? [2]
* there are plenty of data files in /usr/lib 
* /usr/lib/syrthes/3.4.2/example/ will probably be more interesting
in /usr/share/doc/<package>/
* There are static lib into your package. Is it really mandatory ?
/usr/lib/syrthes/3.4.2/lib/Linux/libsatsyrthes3.4.2_Linux.a
/usr/lib/syrthes/3.4.2/lib/Linux/libsyrthes3.4.2_Linux.a
/usr/lib/syrthes/3.4.2/lib/Linux/libmainsyrthes3.4.2_Linux.a

Not blocking:
* the manpages don't explain the arguments syrthes2ensight &
syrthes_create_case 
* In the README.source, you said that you removed the doc directory from
the tarball. 
Could you add a script which can do it automatically ? (a basic script script will be enough See [3])
* I added watch file with the download capabilities with uscan (note that removal script can be plugged straight on it)
* Since control is generated from control.in, you should remove it from the git in order to have confusions.

I hope I am not demotivating you will all these comments... 
Don't hesitate if you have some questions.

Sylvestre
[1] http://debian-science.alioth.debian.org/debian-science-policy.html
[2] /usr/lib/syrthes/3.4.2/example/cylinder/usr/limray.F
/usr/lib/syrthes/3.4.2/example/cylinder/usr/inrefa.F
/usr/lib/syrthes/3.4.2/example/cylinder/usr/cfluvs.F
/usr/lib/syrthes/3.4.2/example/cylinder/usr/initmp.F
/usr/lib/syrthes/3.4.2/example/cylinder/usr/limfso.F
/usr/lib/syrthes/3.4.2/example/cylinder/usr/cphyso.F
/usr/lib/syrthes/3.4.2/example/cylinder/usr/limsol.F
/usr/lib/syrthes/3.4.2/usr/limray.F
/usr/lib/syrthes/3.4.2/usr/inrefa.F
/usr/lib/syrthes/3.4.2/usr/cfluvs.F
/usr/lib/syrthes/3.4.2/usr/initmp.F
/usr/lib/syrthes/3.4.2/usr/limfso.F
/usr/lib/syrthes/3.4.2/usr/cphyso.F
/usr/lib/syrthes/3.4.2/usr/limsol.F
[3] http://svn.debian.org/viewsvn/debian-science/packages/jeuclid/trunk/debian/orig-tar.sh?revision=35400&view=markup