Bug#849661: gap-guava: FTBFS with some SHELLs(?): cd: too many arguments

[Chris West (Faux)]

Source: gap-guava
Version: 3.13+ds-1
Severity: serious
Justification: fails to build from source
Tags: sid stretch
User: reproducible-builds at lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-CC: reproducible-builds at lists.alioth.debian.org

Dear Maintainer,

The package fails to build:

gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/build/gap-guava-3.13+ds/2nd=.
-fstack-protector-strong -Wformat -Werror=format-security
-Wno-unused-result -Wl,-z,relro -Wl,-z,now -o leonconv leonconv.c
cd leon make
/bin/sh: line 0: cd: too many arguments
Makefile:14: recipe for target 'all' failed


There's definitely an error in the Makefile:
https://sources.debian.net/src/gap-guava/3.13%2Bds-1/src/Makefile/#L14

all :   $(FILES)
    cd leon make


The variation appears to be that most shells treat this is "cd leon"
(and ignore the rest of the arguments), whereas some shells reject it as
an error:

% mkdir -p foo bar; for s in bash zsh dash posh sh; do $s -c 'cd foo bar'; done
zsh:cd:1: string not in pwd: foo
posh: cd: too many arguments

(the others succeed)

I have no idea what upstream intended there.

A full build log can be seen on the reproducible-builds builders, which
vary the shell (between bash and.. some sh):
https://tests.reproducible-builds.org/debian/unstable/amd64/gap-guava