Bug#849661: gap-guava: FTBFS with some SHELLs(?): cd: too many arguments

[Jerome BENOIT]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello GUAVA enthusiasts,

@Chris, thanks for report the issue.

On 29/12/16 16:08, Chris West (Faux) wrote:
> Source: gap-guava
> Version: 3.13+ds-1
> Severity: serious
> Justification: fails to build from source
> Tags: sid stretch
> User: reproducible-builds at lists.alioth.debian.org
> Usertags: ftbfs
> X-Debbugs-CC: reproducible-builds at lists.alioth.debian.org
> 
> Dear Maintainer,
> 
> The package fails to build:
> 
> gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
> -fdebug-prefix-map=/build/gap-guava-3.13+ds/2nd=.
> -fstack-protector-strong -Wformat -Werror=format-security
> -Wno-unused-result -Wl,-z,relro -Wl,-z,now -o leonconv leonconv.c
> cd leon make
> /bin/sh: line 0: cd: too many arguments
> Makefile:14: recipe for target 'all' failed
> 

I can reproduce the FTBFS within a schroot Sid environment on my amd64 box with bash as sh.
This shell issue is rather disturbing.

> 
> There's definitely an error in the Makefile:
> https://sources.debian.net/src/gap-guava/3.13%2Bds-1/src/Makefile/#L14
> 
> all :   $(FILES)
>     cd leon make
> 

This code looks insane. I am on my way to attempt to harden it,


> 
> The variation appears to be that most shells treat this is "cd leon"
> (and ignore the rest of the arguments), whereas some shells reject it as
> an error:
> 
> % mkdir -p foo bar; for s in bash zsh dash posh sh; do $s -c 'cd foo bar'; done
> zsh:cd:1: string not in pwd: foo
> posh: cd: too many arguments
> 
> (the others succeed)
> 
> I have no idea what upstream intended there.
> 
> A full build log can be seen on the reproducible-builds builders, which
> vary the shell (between bash and.. some sh):
> https://tests.reproducible-builds.org/debian/unstable/amd64/gap-guava
> 

Thanks,
Jerome


- -- 
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calculus@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B
-----BEGIN PGP SIGNATURE-----

iQQcBAEBCgAGBQJYZvAWAAoJED+SGaZ/NsaLJBAgALNPE1jQx+vhGMGWTiFUJytV
U9s3YDlwrnWN0BC+XIKOYouz7PXxgqZ7n5j4vbFhD2bUARxizYXjedWs7ClidGig
PR2vFyuNHz63PP2NOyDDr+VPr2deIPSSsA1M3V5lJ1jzP6KJeK/JdrWRfMxgmwJT
MdQZoLJsLADbJm+gY05iiK3juKwLkwS3TBRf1YVj9Qk1w+G226c2NLZu/8HylE0y
cJCGUgAMJxiVViwoS6ycVcQ3GE0stAbtIw/Str7sDtAzcylweD6DEwkxg3/sNowT
YB5yXpnELUPOBbM94nwRMOnIXbBjtCjpNS0Rv3ULBiFb/VgNdAijhIdRF+Xh/QxU
ltkvcCmuV6jx7Kp2tKv0xQyktBvEoCq2RWxOsvOKqW3j/7HHa25OWno+icddslUE
6l9sJsN12NO6hQcmJKwNciof6+f7vkTtq6AT5iDWFjlfx6tCVQY1NBJU9EPX/C+P
BvXbXzXtAvP4izAByyTbNiHaylDc8LaXGXMk8AWu1ZWWStI86L8wrL0L3AqF2V2l
648BvPIMgnOc0ljlEN+8ITOSpyzDEtPnNz/jPdIKcuIJ+o8RnAvgQ0xvaFzRz69k
a1IFSeIkAXkNmW06hUN1oTJH8clTsnMCNRmr7QvjbGM9IyWXkCrZz1yQxLfAkQdg
U4fHZmuOl92TyEIePO7V85C/GDB//+1fA2mf//QFFSvN5tfVhY6tXWgRhkLLsi3C
JceuMQl0CIQZIksznlJCT0uO99F6JOdeYuYq5nfXtZriaJCtiLhoAuZmjoUnrind
Iiy7tC6jErgCQ0fluCbCw3sey9joUKKePR8BwDMhZKpvDo4+KU6+gYD8aasqSeaw
euDZi5b73g4eoM7Xz2g9arCLBFnIn8Fd7h9LFHXNtSmK4jsDcL0Pa4TDcsmC9faX
TIj2EZLi9lG0SSU5ChwZ294wegeETw4y9chFYANNyBf/67ixICJtonJUjKDOHEj7
yQCxD9zivwCxMJZyHC1N3aJM/vpQiBAGpQ4H7NgK2KWfjXHkmZSGsaF7MbQLJfqF
iWOAQFyEoeb54gLcZ5rAgy6IdrJ4FzlqL2FKFl9AyvcLGQIg5w6Hl0M3zYwHuyaP
lh6+IDy32tTAgWCWf6L9UWbhK3M5jwcZCsK8OJUhMfSNNtAS2j2wS6M37bI6JAlj
FyD3rkrCXHsZKIBuxvmtwG/zWJ/tGs737aoGlBepNPmTE4R6/s7NtdYOz5tmG2EZ
o+aH9Bhzn0kF6SOBBWtgKbYHuPUpbeCru50m55w7fFd3PJ9vNFJHc9X8dP0KJJbs
BnfqDtLhMy6L7ywRtqVKU+V23Asg1TeQkRLYaXLq1Ox3XU1VM4omRuusXTMlgRc=
=YI3F
-----END PGP SIGNATURE-----