Bug#1045313: togl: Fails to build source after successful build

[Lucas Nussbaum]

Source: togl
Version: 2.0-1.1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package togl
> dpkg-buildpackage: info: source version 2.0-1.1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Holger Levsen <holger at debian.org>
>  dpkg-source --before-build .
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: applying configure.patch
> dpkg-source: info: applying tclconfig-new.patch
>  fakeroot debian/rules clean
> test -x debian/rules
> rm -f debian/stamp-makefile-build debian/stamp-makefile-install
> /usr/bin/make -C . -k distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> cd . \
>   && CONFIG_FILES=Makefile CONFIG_HEADERS= /bin/bash ./config.status
> config.status: creating Makefile
> test -z "libTogl2.0.so libToglstub2.0.a" || rm -f libTogl2.0.so libToglstub2.0.a
> rm -f *.o core *.core
> test -z "so_locations double.o gears.o index.o overlay.o stereo.o texture.o double.so gears.so index.so overlay.so stereo.so texture.so" || rm -f so_locations double.o gears.o index.o overlay.o stereo.o texture.o double.so gears.so index.so overlay.so stereo.so texture.so
> rm -f *.tab.c
> rm -f Makefile pkgIndex.tcl togl_ws.h
> rm -f config.cache config.log config.status
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f debian/stamp-makefile-check
> rm -f debian/stamp-autotools
> rmdir --ignore-fail-on-non-empty .
> rmdir: failed to remove '.': Invalid argument
> make: [/usr/share/cdbs/1/class/autotools.mk:64: makefile-clean] Error 1 (ignored)
> dh_clean 
> dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
> rm -f debian/stamp-autotools-files
> /usr/bin/make -f debian/rules reverse-config
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> make[1]: 'reverse-config' is up to date.
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> if [ -d "." ]; then \
>   cd . && QUILT_PATCHES=/<<PKGBUILDDIR>>/debian/patches quilt --quiltrc /dev/null pop -a -R || test $? = 2 ; \
> fi
> Removing patch tclconfig-new.patch
> Restoring tclconfig/tcl.m4
> 
> Removing patch configure.patch
> Restoring Makefile.in
> 
> No patches applied
> rm -rf ./.pc
> rm -f debian/stamp-patch*
> rm -f libTogl*.so.2.0
> rm -f togl_ws.h
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: applying configure.patch
> dpkg-source: info: applying tclconfig-new.patch
> dpkg-source: info: building togl using existing ./togl_2.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  togl-2.0/configure
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/togl_2.0-1.1.diff.3Z63XV
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/togl_2.0-1.1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.