Bug#1041058: does not respect compilation flags from dpkg-buildflags

[Sébastien Villemot]

Source: ceres-solver
Version: 2.1.0+really2.1.0+dfsg-1
Severity: normal

Dear Maintainer,

The build process of ceres-solver does not respect the flags from
dpkg-buildflags.

More precisely, it unconditionally adds -O3. It means that the default -O2
level is not respected. It also means that DEB_BUILD OPTIONS=noopt does not
work as expected (it should use -O0).

I think this comes from the fact that cmake is passed
-DCMAKE_BUILD_TYPE=Release in debian/rules. The right option to pass for Debian
packaging is -DCMAKE_BUILD_TYPE=None (as is done for example by dh, see
/usr/share/perl5/Debian/Debhelper/Buildsystem/cmake.pm).

Cheers,

--
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  https://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  https://www.debian.org