Bug#1041058: does not respect compilation flags from dpkg-buildflags

[Sébastien Villemot]

Le vendredi 14 juillet 2023 à 16:59 +0200, Sébastien Villemot a écrit :
> The build process of ceres-solver does not respect the flags from
> dpkg-buildflags.
> 
> More precisely, it unconditionally adds -O3. It means that the default -O2
> level is not respected. It also means that DEB_BUILD OPTIONS=noopt does not
> work as expected (it should use -O0).
> 
> I think this comes from the fact that cmake is passed
> -DCMAKE_BUILD_TYPE=Release in debian/rules. The right option to pass for Debian
> packaging is -DCMAKE_BUILD_TYPE=None (as is done for example by dh, see
> /usr/share/perl5/Debian/Debhelper/Buildsystem/cmake.pm).

I just realized that using -O3 is allowed by Policy, if there is a good
reason for using it (see §10.1).

However it is still recommended to support DEB_BUILD_OPTIONS=noopt.

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  https://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  https://www.debian.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/debian-science-maintainers/attachments/20230715/cd02e0d9/attachment-0001.sig>