Bug#1088894: python-escript: FTBFS: dh_install: error: missing files, aborting

[Santiago Vila]

> dh_install: error: missing files, aborting

Hi. I think the reason this package fails to build for me with
such weird error is that there is a "|| true" in line 66 of debian/rules.

That's against Debian Policy 4.6, "Error trapping in makefiles":

https://www.debian.org/doc/debian-policy/ch-source.html#error-trapping-in-makefiles

Please drop such "true" statement (I'm attaching a trivial patch for that).

Unfortunately it will not fix the present bug but at least
will help me to debug it properly.

Also: Please push pending changes to salsa. As much as I'd like
to debug as a team member the very same bug I reported as QA tester,
I still need some collaboration from the team to keep salsa uptodate.

Thanks.
-------------- next part --------------
--- a/debian/rules
+++ b/debian/rules
@@ -63,7 +63,7 @@ override_dh_installchangelogs:
 override_dh_auto_build:
 	# Build steps for py3
 	mkdir -p $(WORK3)
-	(scons $(SFLAGS) cc_optim='$(OPT)'  build_dir=$(BUILD3) verbose=on prefix=$(WORK3) options_file=debian/sid_options.py docs ) || true
+	scons $(SFLAGS) cc_optim='$(OPT)'  build_dir=$(BUILD3) verbose=on prefix=$(WORK3) options_file=debian/sid_options.py docs
 	# extract the relevant .py files
 	cd $(WORK3); $(PROJROOT)/debian/utils/cppy.py $(PROJROOT); cd $(PROJROOT)
 	cp $(PROJROOT)/doc/manpage/man1/run-escript.1 $(WORK3)/run-escript3.man