[Debian-science-sagemath] Package cryptominisat, an optional dependency of SageMath

[Ximin Luo]

Julian Rüth:
> Hello Ximin,
> 
> thanks a lot for having a look. This feedback was extremely helpful. I
> uploaded a new version at
> https://mentors.debian.net/package/cryptominisat that should address all
> the things you pointed out. The only thing I didn't understand is the
> FTBFS:
> 
> * Ximin Luo <infinity0 at debian.org> [2018-08-11 07:20:00 +0000]:
>> Your package FTBFS for me, there is some symbols mismatch:
>>
>> dpkg-gensymbols: warning: debian/libcryptominisat5-5.6/DEBIAN/symbols doesn't match completely debian/libcryptominisat5-5.6.symbols
>> --- debian/libcryptominisat5-5.6.symbols (libcryptominisat5-5.6_5.6.4+dfsg.1-1_amd64)
>> +++ dpkg-gensymbolsk7oqn0	2018-08-11 00:14:36.288737896 -0700
>> @@ -8,13 +8,13 @@
>>   _Z4calcPKSt6vectorIN5CMSat3LitESaIS1_EEbPNS0_16CMSatPrivateDataEb at Base 5.6.3
>>   _Z5fromcPK5c_Lit at Base 5.6.3
>>   _Z5fromcPK7c_lbool at Base 5.6.3
>> - _ZN11MyOccSorterclERKN5CMSat7WatchedES3_ at Base 5.6.3
>> - _ZN12StreamBufferIP8_IO_FILE2FNE8skipLineEv at Base 5.6.3
>> +#MISSING: 5.6.4+dfsg.1-1# _ZN11MyOccSorterclERKN5CMSat7WatchedES3_ at Base 5.6.3
>> +#MISSING: 5.6.4+dfsg.1-1# _ZN12StreamBufferIP8_IO_FILE2FNE8skipLineEv at Base 5.6.3
>> [..]
>> dh_makeshlibs: failing due to earlier errors
>> debian/rules:7: recipe for target 'binary' failed
>> make: *** [binary] Error 2
> 
> I can not reproduce this. How exactly are you building this so I can try
> to understand what might be the issue?
> 

I couldn't reproduce this again either so I've run `dch -m -r` and uploaded your package to NEW. Thanks for your contribution to Debian!

To tie up some loose ends:

I forked your git repo here: https://salsa.debian.org/science-team/cryptominisat - since the Maintainer in d/control says Debian Science Team, that's where we should keep it. Hopefully you already have access, but you can request to join the team on the main team page if you're not already. You can either keep or delete your original repo as you wish.

I've a minor change (by dch, to debian/changelog) to git in the pending-NEW branch, you should merge that into master after it gets ACCEPTED by the Debian FTP masters.

There are also the following minor things you might want to fix later:

gbp:warning: Old style config section [git-buildpackage] found please rename to [buildpackage]
I: cryptominisat source: out-of-date-standards-version 4.1.5 (released 2018-07-04) (current is 4.2.0)
I: libcryptominisat5-5.6: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libcryptominisat5.so.5.6 varible variable
I: python3-cryptominisat: spelling-error-in-binary usr/lib/python3/dist-packages/pycryptosat.cpython-36m-x86_64-linux-gnu.so Occured Occurred
I: python3-cryptominisat: spelling-error-in-binary usr/lib/python3/dist-packages/pycryptosat.cpython-36m-x86_64-linux-gnu.so variabe variable
I: cryptominisat: spelling-error-in-binary usr/bin/cryptominisat5 varables variables

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git