[Debichem-devel] RFS: gelemental and pyelemental

[Cesare Tirabassi]

On Thursday 29 November 2007 16:26:25 you wrote:

Thanks for the comments so far, new version uploaded to mentors for you to 
comment further, if needs be.

> My comments are mostly about using dh_install/dh_move instead of your
> install/move stuff in debian/rules.

Changed but with an hardcoded (even if wildecarded) directory in the .install 
file. I don't like this very much, if also you don't like it we should ask 
Kevin, if possible, to change his Makefile.am from:

docdir = $(datadir)/doc/@PACKAGE at -@VERSION@

to

docdir = $(datadir)/doc/@PACKAGE@

> debian/copyright should be more specific, in which file the data set is 
> you refer to. 

OK, I changed it to point to libelemental/data.cc but note that that file is 
copyrighted GPLv3. I believe Kevin intention was really to quote the 
copyright of the data he used in generating that file (data which is not 
included in the tarball).

> The chosen name of  the application is gElemental, not Gelemental
> (yes, this could be a difference: e.g. JMol vs. Jmol) - see debian/menu.

Changed the menu file, couldn't find anywhere else where to change.

Cheers,

Cesare