[Debichem-devel] ITP: xcrysden -- visualization tool for crystalline structures

[Michael Banck]

Hi,

On Fri, Mar 09, 2012 at 09:25:27PM +0100, Tone Kokalj wrote:
> I updated xcrysden debianized package according to your guidelines. New
> package is available on:
> 
> http://www.xcrysden.org/download/debian/
> 
> The uploaded version is 1.5.51, but this is essentially 1.6 that will be
> released shortly. Let me know if you find some issues, and I will adopt
> accordingly. Do you have some time estimate when xcrysden can/will be
> uploaded to Debian?

I just had a go, but there is one small problem: If I build it with
sbuild (like on the Debian autobuilders), I get a failure because $(PWD)
is not in the environment (probably stripped by schroot or sudo), and
TOPDIR is set to it in Makefile.  So I get a failure like

dh_auto_build -- xcrysden
make[2]: *** No rule to make target `/docs/xcrysden.1', needed by
`usage'.  Stop.

If I set $(PWD) explicitly, the build goes fine for me:

override_dh_auto_build:
	PWD=$(CURDIR) dh_auto_build -- xcrysden

Or you could change Makefile to get $(PWD) via a shell command or so I
guess.

Second, the patches provoke some warnings because they are slightly
malformed:

* fixing DESTDIR issue and xcrysden directory name in Makefile--- a/Makefile
+++ b/Makefile
[...]

The `---' should be on a new line, but as far as I can tell, they still
get applied.

Other than that, the package looks fine and I will upload it as soon as
the above is fixed.


Cheers,

Michael