[Debichem-devel] ITP: xcrysden -- visualization tool for crystalline structures

[Tone Kokalj]

On Sat, 2012-03-10 at 14:47 +0100, Michael Banck wrote:
> I just had a go, but there is one small problem: If I build it with
> sbuild (like on the Debian autobuilders), I get a failure because $(PWD)
> is not in the environment (probably stripped by schroot or sudo), and
> TOPDIR is set to it in Makefile.  So I get a failure like
> 
> dh_auto_build -- xcrysden
> make[2]: *** No rule to make target `/docs/xcrysden.1', needed by
> `usage'.  Stop.
> 
> If I set $(PWD) explicitly, the build goes fine for me:
> 
> override_dh_auto_build:
> 	PWD=$(CURDIR) dh_auto_build -- xcrysden
> 
> Or you could change Makefile to get $(PWD) via a shell command or so I
> guess.

I changed the top Makefile by substituting PWD with CURDIR. 


> Second, the patches provoke some warnings because they are slightly
> malformed:
> 
> * fixing DESTDIR issue and xcrysden directory name in Makefile--- a/Makefile
> +++ b/Makefile
> [...]
> 
> The `---' should be on a new line, but as far as I can tell, they still
> get applied.

I corrected all such occurrences by adding a newline.
 
The updated package is available at:
http://www.xcrysden.org/download/debian/

Let me know if some new (remaining) issues still appear.

Regards, Tone


-- 
Anton Kokalj
J. Stefan Institute, Jamova 39, 1000 Ljubljana, Slovenia 
(tel: +386-1-477-3523 // fax:+386-1-477-3822)

Please, if possible, avoid sending me Word or PowerPoint attachments.
See:  http://www.gnu.org/philosophy/no-word-attachments.html