[Debichem-devel] Bug#759860: pymol: FTBFS: contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp:1986:31: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: pymol
Version: 1.7.1.3-1
Severity: serious
Tags: jessie sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20140830 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_PYMOL_LIBPNG -D_PYMOL_INLINE -D_PYMOL_OPENGL_SHADERS -D_PYMOL_CGO_DRAWARRAYS -D_PYMOL_CGO_DRAWBUFFERS -D_PYMOL_GL_CALLLISTS -D_PYMOL_VMD_PLUGINS -D_PYMOL_FREETYPE -DNO_MMLIBS -D_CGO_DRAWARRAYS -DOPENGL_ES_2 -D_PYMOL_NUMPY -Iov/src -Ilayer0 -Ilayer1 -Ilayer2 -Ilayer3 -Ilayer4 -Ilayer5 -Imodules/cealign/src -Imodules/cealign/src/tnt -Ibuild/generated -Icontrib/uiuc/plugins/include -Icontrib/uiuc/plugins/molfile_plugin/src -I/usr/lib/python2.7/dist-packages/numpy/core/include -I/usr/include -I/usr/include/freetype2 -I/usr/include/python2.7 -c contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp -o build/temp.linux-x86_64-2.7/contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.o -ffast-math -funroll-loops -O3 -fcommon
> cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
> contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp: In function 'int {anonymous}::write_structure(void*, int, const molfile_atom_t*)':
> contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp:1883:9: warning: unused variable 'last_ctnumber' [-Wunused-variable]
>      int last_ctnumber = -1;
>          ^
> contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp: In function 'int {anonymous}::write_timestep(void*, const molfile_timestep_t*)':
> contrib/uiuc/plugins/molfile_plugin/src/maeffplugin.cpp:1986:31: error: format not a string literal and no format arguments [-Werror=format-security]
>        fprintf(stderr, e.what());
>                                ^
> cc1plus: some warnings being treated as errors
> error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
> dh_auto_build: python setup.py build --force returned exit code 1
> make[1]: *** [override_dh_auto_build] Error 1

The full build log is available from:
   http://aws-logs.debian.net/ftbfs-logs/2014/08/30/pymol_1.7.1.3-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures. The build
was done with DEB_BUILD_OPTIONS="parallel=4", so if your packaging tries
to support this, it might be a good idea to explore whether this might
be the cause of the failure.