[Fusioninventory-devel] [Fusioninventory-commit] [fusinv/fusioninventory-agent] 4bae98: httpd-trust: allow multi IP and fulltext hostname

[Guillaume Rousse]

Le 19/07/2012 11:46, Gonéri Le Bouder a écrit :
>    Branch: refs/heads/2.3.x+extended_httpd-trust
>    Home:   https://github.com/fusinv/fusioninventory-agent
>    Commit: 4bae98412b61b628fdac640cbd3f6f159c58c657
>        https://github.com/fusinv/fusioninventory-agent/commit/4bae98412b61b628fdac640cbd3f6f159c58c657
>    Author: Gonéri Le Bouder <goneri at rulezlan.org>
>    Date:   2012-07-19 (Thu, 19 Jul 2012)
>
>    Changed paths:
>      M lib/FusionInventory/Agent/HTTP/Server.pm
>
>    Log Message:
>    -----------
>    httpd-trust: allow multi IP and fulltext hostname
Excellent idea, but I'd prefer to keep multi valued option handling in 
Config.pm, and deal with perl lists in the rest of the code.

Also, minor cosmetic issues:
- every non-trivial loop should use explicit iterators:
foreach (split(/,/, $self->{trust})) -> foreach my $something 
(split(/,/, $self->{trust}))
- error message format is usually: "can't do something: $error", not 
"can't do something - $error"

-- 
BOFH excuse #60:

system has been recalled