[Fusioninventory-devel] [Fusioninventory-commit] [fusinv/fusioninventory-agent] 4bae98: httpd-trust: allow multi IP and fulltext hostname

Gonéri Le Bouder goneri at rulezlan.org
Tue Jul 31 08:27:29 UTC 2012


2012/7/20 Guillaume Rousse <guillomovitch at gmail.com>:
> Le 19/07/2012 11:46, Gonéri Le Bouder a écrit :

> Excellent idea, but I'd prefer to keep multi valued option handling in
> Config.pm, and deal with perl lists in the rest of the code.
It deserve
>
> Also, minor cosmetic issues:
> - every non-trivial loop should use explicit iterators:
> foreach (split(/,/, $self->{trust})) -> foreach my $something (split(/,/,
> $self->{trust}))
> - error message format is usually: "can't do something: $error", not "can't
> do something - $error"
Hi Guillaume,

As you may have notified, I commited a patch with your comment.

Regards,
-- 
     Gonéri Le Bouder



More information about the Fusioninventory-devel mailing list