[PATCH] - Adding timestamps to terminal output

Adam Lackorzynski adam at os.inf.tu-dresden.de
Mon Feb 28 19:10:56 UTC 2011


On Mon Feb 28, 2011 at 11:36:50 +0000, Mark Einon wrote:
> On 20 February 2011 11:38, Adam Lackorzynski <adam at os.inf.tu-dresden.de> wrote:
> > Hi,
> >
> > On Sat Feb 19, 2011 at 15:48:41 +0000, Mark Einon wrote:
> >> On 19 February 2011 14:03, Adam Lackorzynski <adam at os.inf.tu-dresden.de> wrote:
> >> > I applied it and further modified it. I like it more when the timestamp
> >> > always prepends each line. What do you think?
> >>
> >> I did consider that approach, and it isn't hard to change to use it,
> >> or even make it configurable. I decided against it because:
> >>
> >> 1. The log files produced are greatly increased in size (especially
> >> for an overnight run).
> >> 2. Terminals that have limited width (e.g 80 lines) get wrapped /
> >> truncated lines more often
> >> 3. Each line printed would go through the process of formatting the
> >> timestamp, which may cause issues on slower machines - although
> >> thinking about it again, you only have to format the timestamp string
> >> when the time changes, so this can be mitigated.
> >
> > Ok. So I made the timestamping a three value thing now, adding a 'once
> > per second' choice. That should cover both options.
> 
> Great, seems to work well. I've attached a patch to change the help
> string from 'on/off' to 'toggle' which is more accurate. It's not
> totally transparent what it does, but it suffices...

Yep, committed.


Thanks!
Adam
-- 
Adam                 adam at os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/



More information about the minicom-devel mailing list