[Nut-upsdev] A minor nit to pick

Alfred Ganz alfred-ganz+nut at agci.com
Wed Oct 26 14:47:14 UTC 2005


Ladies and Gentlemen,

Running newhidups with -DD shows the following line that starts with 
"-> String:" occasionally, with no contect that it is related to:
......
Can't find object UPS.Battery.Temperature
-> String: PbAc (len = 4/4)
Can't find object UPS.Output.PercentLoad
......

However, running newhidups with -DDD, shows the proper context:
......
hu_find_infoval: searching for value = 4

-> String: PbAc (len = 4/4)
hu_find_infoval: found PbAc (value: 4)
......
since the upsdebugx() statements there are at level 3.

May I suggest that the following TRACE statement in in libusb_get_string()
in lubusb.c be changed to level 3:
---------------------------------------------------------------------------
          ret = usb_get_string_simple(udev, StringIdx, string, 20); /* sizeof(string)); */
          if (ret > 0)
                {
                  TRACE(2, "-> String: %s (len = %i/%i)", string, ret, sizeof(string));
                }
---------------------------------------------------------------------------

I know it is minor, but anyhow! Thanks, AG

-- 
 ----------------------------------------------------------------------
   Alfred Ganz					alfred-ganz at agci.com
   AG Consulting, Inc.				(203) 624-9667
   440 Prospect Street # 11
   New Haven, CT 06511
 ----------------------------------------------------------------------



More information about the Nut-upsdev mailing list