[Nut-upsdev] Re: Patch for optiups to support Zinto D from ONLINE

[Peter Selinger]

Scott Heavner is the author of the optiups driver. Scott, are you
receiving this? Could you audit Matthias' patch and test whether it
breaks anything? -- Peter

Matthias Goebl wrote:
> 
> Hello Peter,
> 
> I modified the driver to autodetect the Zinto D (I hope without touching
> optiups-support) and updated the documentation, the appended patch is
> against the svn-trunk.
> 
> Yours,
> Matthias
> 
> 
> Hi list,
> 
> I don't know, whether it supports other ups from ONLINE-USV, but if someone
> has results with other ups, please report it.
> 
> mg
> 
> 
> On Sun, Nov 26, 2006 at 12:40:44PM -0400, Peter Selinger wrote:
> > Matthias,
> > 
> > NUT drivers should always detect devices automatically if possible,
> > rather than requiring the user to set a variable such as "zinto". 
> > 
> > Can you modify upsdrv_initinfo to detect the device type based on the
> > model string (and/or if necessary, based on ups.mfr)? -- Peter
> > 
> > Matthias Goebl wrote:
> > > 
> > > 
> > > Hi Arnaud,
> > > Hi Scott,
> > > Hi list,
> > > 
> > > Here is a patch to support the Zinto D from ONLINE USV-Systeme AG.
> > > I already sent a version to Russell Kroll (2006-04-09), without no response
> > > and I cannot find support for Zinto in svn until now.
> > > I found a discussion on this list about the Xanto from ONLINE, but the Zinto
> > > seems to use different commands.
> > > 
> > > The commands are quite similar to those for Opti-UPS, so I decided not to fork,
> > > but to patch optiups. Where I found differences, I added if(testvar(OPTI_ZINTO)).
> > > As soon as someone adds another device with similar commands, one could decide
> > > how to differentiate within the driver (where to use select-case).
> > > What do you think?
> > > 
> > > Yours,
> > > Matthias