[Nut-upsdev] Re: [PATCH] upsstatus += HB, TEST

[Arnaud Quette]

2007/1/17, Peter Selinger <selinger at mathstat.dal.ca>:
> Arjen de Korte wrote:
> >
> > Kirill Smelkov wrote:
> >
> > > Here I propose 2 new status flags for inclusion into NUT:
> > >
> > >   HB    - HighBattery
> >
> > What is this? Is this a notification that the battery is full, or that
> > the battery voltage is too high? At the very least, this should be a
> > little more descriptive. Yet I'm not quite sure if this is not similar
> > to RB (Replace Battery).
>
> Perhaps this is just the negation of LB - Low Battery? In this case it
> is not needed as a separate flag.

battery.charge = 100 would also do it.

> > >   TEST  - Battery test is running
> >
> > We already have CAL, which is essentially the same thing. Unless this is
> > totally different, I don't support adding this to the ups.status. For
> > the operation of upsmon, a battery test and runtime calibration are the
> > same thing - you'd risk a shorter than normal runtime when the mains is
> > out (if the battery is not fully charged).
>
> Perhaps this belongs in ups.test.result? Several drivers put "in
> progress" here while a test is in progress.

that what we have for example in newhidups and mge-shut for ups.test.result:
"Done and passed"
"Done and warning"
"Done and error"
"Aborted"
"In progress"
"No test initiated"

Maybe standardizing a bit these value would help others...

> > For now, I don't support either of these two flags.
>
> Neither I. -- Peter

seconded

thanks to Kirill for following up,
Arnaud
-- 
Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://people.debian.org/~aquette/
OpenSource Developer - http://arnaud.quette.free.fr/