[Nut-upsdev] Changes to usbhid-ups driver

Arjen de Korte nut+devel at de-korte.org
Tue Sep 4 18:44:51 UTC 2007


Peter Selinger wrote:

>> I just applied the patch (r1087) to make this effective (ie, let the
>> belkin_format_serial() function modify hd->Serial, instead of just
>> returning a pointer to the serial number). Is the same valid for the
>> (usb_device *)descriptor.iManufacturer and (usb_device
>> *)descriptor.iProduct by the way? There is no reason why we couldn't do
>> the same for belkin_format_mfr() and belkin_format_model(), if that is
>> useful.
> Yes, that information is also unavailable in the usb_device
> structure. I don't currently remember whether it is in the UPS.*
> hierarchy, but I think it isn't. The belkin_format_mfr() etc functions
> just return generic values unless better info is available. (From the
> vendorid, we do know the manufacturer is Belkin). 

Are these in HIDDumpTree maybe? It's a real simple addition to the
subdriver (see r1087) and having the actual productname instead of just
'unknown' would be nice.

Best regards, Arjen



More information about the Nut-upsdev mailing list