[Nut-upsdev] [Nut-upsuser] genericups CP custom config not working

[Charles Lepple]

On Feb 13, 2008 3:38 AM, Arjen de Korte <nut+devel at de-korte.org> wrote:
> > Do any of you see any reason why we shouldn't move the signal
> > overrides out of upsdrv_initinfo() and into upsdrv_initups()?
>
> Well, other than the fact that overriding the OL and LB signals in
> upsdrv_initups() is not needed (since these signals are irrelevant until
> we call upsdrv_updateinfo() for the first time), this is probably a good
> idea.

You're right that the input signals are irrelevant at first, but it
also makes sense to keep all of the configuration code together.

> > I think the original poster's problem would also manifest itself as an
> > inability to shut down, if any of the shutdown signals have been
> > overridden (since the shutdown function would be called before
> > upsdrv_initinfo() as well).
>
> Indeed, but with the restriction to limit this to the CP and SD signals.
> Time permitting, I will update the driver later today.
>
> Best regards, Arjen
> --
> Eindhoven - The Netherlands
> Key fingerprint - 66 4E 03 2C 9D B5 CB 9B  7A FE 7E C1 EE 88 BC 57
>
>



-- 
- Charles Lepple