[Nut-upsdev] Path for .fdi files (was: Re: [nut-commits] buildbot failure in FreeBSD-i686)

Arjen de Korte nut+devel at de-korte.org
Sat Dec 26 22:13:00 UTC 2009

Citeren Arjen de Korte <nut+devel op de-korte.org>:

>> Should we be checking ${datarootdir} in the 'test' line?
> Looking at the contents of m4/nut_check_libhal.m4 now, we probably should.

Never mind this remark. At the time this test is run, it looks like  
this variable isn't expanded yet, so this will fail miserably. So I've  
reverted back to the change you made.

I also doubt if line 77 is actually doing something. It fails to  
detect the '${libdir}/hal' directory on OpenSUSE (which uses a similar  
layout as Debian):

77		if (test -d "${libdir}/hal"); then
78			# For Debian
79			HAL_CALLOUTS_PATH="${libdir}/hal"

I question if constructions like this will ever match. On OpenSUSE it  
will fallback to the default

89		else
90			# FIXME
91			HAL_CALLOUTS_PATH="${libdir}/hal"
92			AC_MSG_RESULT(using default (${HAL_CALLOUTS_PATH}))

which happens to result in the same. In the patches for OpenSUSE 11.2  
something similar is also added, to prevent it from relying on the  
default action.

@Arnaud: Can you check what happened on Debian before I committed  
r2202, adding a test for '/usr/lib/hal'? The BuildBot we currently use  
doesn't have HAL support, so we can't test this.

Best regards, Arjen
Please keep list traffic on the list

More information about the Nut-upsdev mailing list