[Nut-upsdev] liebert esp2 new version + crest factor

Arjen de Korte nut+devel at de-korte.org
Wed Apr 14 07:16:56 UTC 2010


Citeren Spiros Ioannou <sivann op gmail.com>:

> 1) I'm planning on adding lots of measurements to the driver liebert-esp2 +
> correct support for 3-phase systems. Should I make a large patch based on
> the last svn head or send you the whole file? Multiple patches per change
> are probably not practical in this case.

If possible, separate patches that modify existing code/behavior from  
patches that add new functionality/variables. The latter are less  
likely to break existing installations.

> 2) in http://www.networkupstools.org/doc/2.2.0/new-names.html there is no
> crest factor variable. Crest factor is very important for large
> installations. Should I add a new variable named crestfactor ? (Crest factor
> shows the ratio between the peak and the RMS)

I added 'output.crestfactor' and 'outlet.n.crestfactor' to the list of  
supported variables.

Best regards, Arjen
-- 
Please keep list traffic on the list




More information about the Nut-upsdev mailing list