[Nut-upsdev] liebert-esp2 patch (3-phase support)

[Spiros Ioannou]

I've found the bits containing the multipliers, but It may take time to find
which is which. There are ~15 "multiplier" values hidden in ~70 bits. It may
be impossible to guess which is which with just 2 sets of outputs (from 2
models).

What I can do is get a glimpse on a part of those bit values on driver
startup and decide for all multipliers with a "switch/case" , having 2
cases. That will work for the two models we have data for. If we get another
model, then we can add more cases. That seems reasonable and easily
expandable and will avoid deciphering the bits.

-S


On Sun, Apr 25, 2010 at 9:00 PM, Arjen de Korte
<nut+devel at de-korte.org<nut%2Bdevel at de-korte.org>
> wrote:

> Citeren Robert Jobbagy <jobbagy.robert at gmail.com>:
>
>
>  I think it will be good if the driver check the model of ups (NX or GXT2)
>> and
>> the model is GXT2 then input and output values multipliers will be 0.1
>> else
>> 0.01.
>> The driver could to use #ifdef preprocess struct.
>>
>
> The latter would require different drivers (since #ifdef statements are
> processed by the preprocessor, so even before the compiler). Packagers that
> wish to bundle precompiled binaries would then have to bundle two different
> drivers.
>
>  What is your opinion?
>>
>
> Since the differences between the models are so minor, expect me to veto
> such a change. If there is no way to autodetect this, the driver should
> default to the settings for the most popular model (usually the smallest)
> and allow people to override the default setting in 'ups.conf'. If you can't
> unambiguously determine which multiplier is needed, usually this will cause
> the least amount of problems.
>
> Best regards, Arjen
> --
> Please keep list traffic on the list
>
>
>
> _______________________________________________
> Nut-upsdev mailing list
> Nut-upsdev at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20100426/e45cc926/attachment.htm>